Re: [PATCH] perf tools: Fix perf version generation

2013-07-01 Thread Borislav Petkov
Hey acme, is this one in some queue already? I just saw the same problem on 3.10 because git-tag sorts the output alphanumerically so that all tags starting with "v3.10" do not appear last and thus the "tail -1" doesn't work anymore. So on 3.10 you end up with perf version 3.9.rc8.g8bb495. On W

Re: [PATCH] perf tools: Fix perf version generation

2013-05-10 Thread Robert Richter
On 08.05.13 22:01:01, Runzhen Wang wrote: > # ./perf --version > perf version 3.9.1 > > your patch works when the repo only has commit info but no tags > info, but I confuse that whether this situation is Real? > > Maybe you prepare for a RARE case but increase the code's **Complexity** ? It wor

Re: [PATCH] perf tools: Fix perf version generation

2013-05-08 Thread Runzhen Wang
On 05/08/2013 07:06 PM, Robert Richter wrote: On 08.05.13 18:39:07, Xiao Guangrong wrote: I remember that Wang has posted a similar patch to fix this bug several weeks ago: http://lkml.org/lkml/2013/4/24/70 But have no response yet. Yes, this patch would fix the version tag too. The patch

Re: [PATCH] perf tools: Fix perf version generation

2013-05-08 Thread Robert Richter
On 08.05.13 18:39:07, Xiao Guangrong wrote: > I remember that Wang has posted a similar patch to fix this bug several > weeks ago: > http://lkml.org/lkml/2013/4/24/70 > > But have no response yet. Yes, this patch would fix the version tag too. The patch I wrote also reports a commit id eve

Re: [PATCH] perf tools: Fix perf version generation

2013-05-08 Thread Xiao Guangrong
On 05/08/2013 05:43 PM, Robert Richter wrote: > From: Robert Richter > > The tag of the perf version is wrongly determined, always the latest > tag is taken regardless of the HEAD commit: > > $ perf --version > perf version 3.9.rc8.gd7f5d3 > $ git describe d7f5d3 > v3.9-rc7-154-gd7f5d33 > $

[PATCH] perf tools: Fix perf version generation

2013-05-08 Thread Robert Richter
From: Robert Richter The tag of the perf version is wrongly determined, always the latest tag is taken regardless of the HEAD commit: $ perf --version perf version 3.9.rc8.gd7f5d3 $ git describe d7f5d3 v3.9-rc7-154-gd7f5d33 $ head -n 4 Makefile VERSION = 3 PATCHLEVEL = 9 SUBLEVEL = 0 EX