Re: [PATCH] perf tools: Fix "Command" sort_entry's cmp and collapse function

On Mon, May 18, 2015 at 10:38:50AM +0900, Namhyung Kim wrote: > Hi Jiri, > > CC-ing Frederic as he wrote the comm change. > > On Fri, May 15, 2015 at 05:54:28PM +0200, Jiri Olsa wrote: > > Currently the se_cmp and se_collapse use pointer comparison, > > which is ok for for testing equality of str

Re: [PATCH] perf tools: Fix "Command" sort_entry's cmp and collapse function

Hi Jiri, CC-ing Frederic as he wrote the comm change. On Fri, May 15, 2015 at 05:54:28PM +0200, Jiri Olsa wrote: > Currently the se_cmp and se_collapse use pointer comparison, > which is ok for for testing equality of strings. It's not ok > as comparing function for rbtree insertion, because it g

[PATCH] perf tools: Fix "Command" sort_entry's cmp and collapse function

Currently the se_cmp and se_collapse use pointer comparison, which is ok for for testing equality of strings. It's not ok as comparing function for rbtree insertion, because it gives different results based on current pointer values. We saw test 32 (hists cumulation test) failing based on differen