Re: [PATCH] perf tests: Fix regex for record+probe_libc_inet_pton.sh

2018-05-21 Thread Thomas-Mich Richter
On 05/18/2018 04:14 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, May 18, 2018 at 01:09:48PM +0200, Thomas-Mich Richter escreveu: >> On 05/18/2018 12:29 PM, Sandipan Das wrote: >>> Can you please apply these two patches as well and then re-test? > >>> [1] https://lkml.org/lkml/2018/5/17/112 >>> [2

Re: [PATCH] perf tests: Fix regex for record+probe_libc_inet_pton.sh

2018-05-18 Thread Arnaldo Carvalho de Melo
Em Fri, May 18, 2018 at 04:29:16PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, May 18, 2018 at 04:21:02PM -0300, Arnaldo Carvalho de Melo escreveu: > > Here it went from failing with: > > > > [root@seventh ~]# perf test -v pton > > 64: probe libc's inet_pton & backtrace it with ping

Re: [PATCH] perf tests: Fix regex for record+probe_libc_inet_pton.sh

2018-05-18 Thread Arnaldo Carvalho de Melo
Em Fri, May 18, 2018 at 04:21:02PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, May 18, 2018 at 12:54:17PM +0530, Sandipan Das escreveu: > > This test currently fails because the regular expressions for > > matching the output of perf script do not consider the symbol > > offsets to be part

Re: [PATCH] perf tests: Fix regex for record+probe_libc_inet_pton.sh

2018-05-18 Thread Sandipan Das
Hi Arnaldo, On 05/19/2018 12:51 AM, Arnaldo Carvalho de Melo wrote: > Em Fri, May 18, 2018 at 12:54:17PM +0530, Sandipan Das escreveu: >> This test currently fails because the regular expressions for >> matching the output of perf script do not consider the symbol >> offsets to be part of the outp

Re: [PATCH] perf tests: Fix regex for record+probe_libc_inet_pton.sh

2018-05-18 Thread Arnaldo Carvalho de Melo
Em Fri, May 18, 2018 at 12:54:17PM +0530, Sandipan Das escreveu: > This test currently fails because the regular expressions for > matching the output of perf script do not consider the symbol > offsets to be part of the output. > > The symbol offsets are seen because of the default behaviour > in

Re: [PATCH] perf tests: Fix regex for record+probe_libc_inet_pton.sh

2018-05-18 Thread Arnaldo Carvalho de Melo
Em Fri, May 18, 2018 at 11:14:45AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, May 18, 2018 at 01:09:48PM +0200, Thomas-Mich Richter escreveu: > > On 05/18/2018 12:29 PM, Sandipan Das wrote: > > > Can you please apply these two patches as well and then re-test? > > > > [1] https://lkml.org

Re: [PATCH] perf tests: Fix regex for record+probe_libc_inet_pton.sh

2018-05-18 Thread Arnaldo Carvalho de Melo
Em Fri, May 18, 2018 at 01:09:48PM +0200, Thomas-Mich Richter escreveu: > On 05/18/2018 12:29 PM, Sandipan Das wrote: > > Can you please apply these two patches as well and then re-test? > > [1] https://lkml.org/lkml/2018/5/17/112 > > [2] https://lkml.org/lkml/2018/5/17/113 > Ahhh, yes that helpe

Re: [PATCH] perf tests: Fix regex for record+probe_libc_inet_pton.sh

2018-05-18 Thread Thomas-Mich Richter
On 05/18/2018 12:29 PM, Sandipan Das wrote: > Hi Thomas, > > On 05/18/2018 03:51 PM, Thomas-Mich Richter wrote: > [...] >> >> This patch fails on s390. I used 4.17.0rc5 + fedora 27 and I get this output: >> >> >> [root@p23lp27 perf]# ./perf test 59 >> 59: probe libc's inet_pton & backtrace it with

Re: [PATCH] perf tests: Fix regex for record+probe_libc_inet_pton.sh

2018-05-18 Thread Sandipan Das
Hi Thomas, On 05/18/2018 03:51 PM, Thomas-Mich Richter wrote: [...] > > This patch fails on s390. I used 4.17.0rc5 + fedora 27 and I get this output: > > > [root@p23lp27 perf]# ./perf test 59 > 59: probe libc's inet_pton & backtrace it with ping : Ok > [root@p23lp27 linux]# cd ~/linux; pa

Re: [PATCH] perf tests: Fix regex for record+probe_libc_inet_pton.sh

2018-05-18 Thread Thomas-Mich Richter
On 05/18/2018 09:24 AM, Sandipan Das wrote: > This test currently fails because the regular expressions for > matching the output of perf script do not consider the symbol > offsets to be part of the output. > > The symbol offsets are seen because of the default behaviour > introduced by commit 41

[PATCH] perf tests: Fix regex for record+probe_libc_inet_pton.sh

2018-05-18 Thread Sandipan Das
This test currently fails because the regular expressions for matching the output of perf script do not consider the symbol offsets to be part of the output. The symbol offsets are seen because of the default behaviour introduced by commit 4140d2ea74b3 ("perf script: Show symbol offsets by default