Re: [PATCH] perf stat: Fix shadow stats for clock events

2018-11-27 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 27, 2018 at 01:50:44PM +0530, Ravi Bangoria escreveu: > > > On 11/16/18 7:05 PM, Jiri Olsa wrote: > > On Fri, Nov 16, 2018 at 09:58:43AM +0530, Ravi Bangoria wrote: > >> Commit 0aa802a79469 ("perf stat: Get rid of extra clock display > >> function") introduced scale and unit for clock

Re: [PATCH] perf stat: Fix shadow stats for clock events

2018-11-27 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 16, 2018 at 02:35:55PM +0100, Jiri Olsa escreveu: > On Fri, Nov 16, 2018 at 09:58:43AM +0530, Ravi Bangoria wrote: > > Commit 0aa802a79469 ("perf stat: Get rid of extra clock display > > function") introduced scale and unit for clock events. Thus, > > perf_stat__update_shadow_stats() no

Re: [PATCH] perf stat: Fix shadow stats for clock events

2018-11-27 Thread Ravi Bangoria
On 11/16/18 7:05 PM, Jiri Olsa wrote: > On Fri, Nov 16, 2018 at 09:58:43AM +0530, Ravi Bangoria wrote: >> Commit 0aa802a79469 ("perf stat: Get rid of extra clock display >> function") introduced scale and unit for clock events. Thus, >> perf_stat__update_shadow_stats() now saves scaled values of

Re: [PATCH] perf stat: Fix shadow stats for clock events

2018-11-16 Thread Jiri Olsa
On Fri, Nov 16, 2018 at 09:58:43AM +0530, Ravi Bangoria wrote: > Commit 0aa802a79469 ("perf stat: Get rid of extra clock display > function") introduced scale and unit for clock events. Thus, > perf_stat__update_shadow_stats() now saves scaled values of > clock events in msecs, instead of original

[PATCH] perf stat: Fix shadow stats for clock events

2018-11-15 Thread Ravi Bangoria
Commit 0aa802a79469 ("perf stat: Get rid of extra clock display function") introduced scale and unit for clock events. Thus, perf_stat__update_shadow_stats() now saves scaled values of clock events in msecs, instead of original nsecs. But while calculating values of shadow stats we still consider c