Re: [PATCH] perf stat: Fail on extra comma while parsing events

2020-05-20 Thread Arnaldo Carvalho de Melo
Em Wed, May 20, 2020 at 12:51:24AM -0700, Ian Rogers escreveu: > On Wed, May 20, 2020 at 12:41 AM Jiri Olsa wrote: > > > > Ian reported that we allow to parse following: > > > > $ perf stat -e ,cycles true > > > > which is wrong and we should fail, like we do with this fix: > > > > $ perf stat

Re: [PATCH] perf stat: Fail on extra comma while parsing events

2020-05-20 Thread Ian Rogers
On Wed, May 20, 2020 at 12:41 AM Jiri Olsa wrote: > > Ian reported that we allow to parse following: > > $ perf stat -e ,cycles true > > which is wrong and we should fail, like we do with this fix: > > $ perf stat -e ,cycles true > event syntax error: ',cycles' > \___

[PATCH] perf stat: Fail on extra comma while parsing events

2020-05-20 Thread Jiri Olsa
Ian reported that we allow to parse following: $ perf stat -e ,cycles true which is wrong and we should fail, like we do with this fix: $ perf stat -e ,cycles true event syntax error: ',cycles' \___ parser error The reason is that we don't have rule for ',' in 'eve