Re: [PATCH] perf stat: Align CSV output for summary mode

2021-03-16 Thread Jin, Yao
On 3/17/2021 9:30 AM, Andi Kleen wrote: Is it serious or just a joke? :) I would prefer to not be compatible (at least not until someone complains), but if compatibility is required then yes opting in to the broken format would be better. Perhaps not with that name. And the option could be

Re: [PATCH] perf stat: Align CSV output for summary mode

2021-03-16 Thread Andi Kleen
> Is it serious or just a joke? :) I would prefer to not be compatible (at least not until someone complains), but if compatibility is required then yes opting in to the broken format would be better. Perhaps not with that name. And the option could be hidden in the perf config file instead of be

Re: [PATCH] perf stat: Align CSV output for summary mode

2021-03-16 Thread Jin, Yao
On 3/17/2021 5:55 AM, Jiri Olsa wrote: On Tue, Mar 16, 2021 at 01:02:20PM -0700, Andi Kleen wrote: On Tue, Mar 16, 2021 at 04:05:13PM -0300, Arnaldo Carvalho de Melo wrote: Em Tue, Mar 16, 2021 at 09:34:21AM -0700, Andi Kleen escreveu: looks ok, but maybe make the option more related to CVS,

Re: [PATCH] perf stat: Align CSV output for summary mode

2021-03-16 Thread Jiri Olsa
On Tue, Mar 16, 2021 at 01:02:20PM -0700, Andi Kleen wrote: > On Tue, Mar 16, 2021 at 04:05:13PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Mar 16, 2021 at 09:34:21AM -0700, Andi Kleen escreveu: > > > > looks ok, but maybe make the option more related to CVS, like: > > > > > > > > --x-su

Re: [PATCH] perf stat: Align CSV output for summary mode

2021-03-16 Thread Andi Kleen
On Tue, Mar 16, 2021 at 04:05:13PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Mar 16, 2021 at 09:34:21AM -0700, Andi Kleen escreveu: > > > looks ok, but maybe make the option more related to CVS, like: > > > > > > --x-summary, --cvs-summary ...? > > > > Actually I don't think it should

Re: [PATCH] perf stat: Align CSV output for summary mode

2021-03-16 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 16, 2021 at 09:34:21AM -0700, Andi Kleen escreveu: > > looks ok, but maybe make the option more related to CVS, like: > > > > --x-summary, --cvs-summary ...? > > Actually I don't think it should be a new option. I doubt > anyone could parse the previous mess. So just make it defau

Re: [PATCH] perf stat: Align CSV output for summary mode

2021-03-16 Thread Andi Kleen
> looks ok, but maybe make the option more related to CVS, like: > > --x-summary, --cvs-summary ...? Actually I don't think it should be a new option. I doubt anyone could parse the previous mess. So just make it default with -x -Andi

Re: [PATCH] perf stat: Align CSV output for summary mode

2021-03-16 Thread Jiri Olsa
On Tue, Mar 16, 2021 at 02:07:12PM +0100, Jiri Olsa wrote: > On Tue, Mar 16, 2021 at 03:29:00PM +0800, Jin Yao wrote: > > perf-stat has supported the summary mode. But the summary > > lines break the CSV output so it's hard for scripts to parse > > the result. > > > > Before: > > > > # perf sta

Re: [PATCH] perf stat: Align CSV output for summary mode

2021-03-16 Thread Jiri Olsa
On Tue, Mar 16, 2021 at 03:29:00PM +0800, Jin Yao wrote: > perf-stat has supported the summary mode. But the summary > lines break the CSV output so it's hard for scripts to parse > the result. > > Before: > > # perf stat -x, -I1000 --interval-count 1 --summary >1.001323097,8013.48,msec

[PATCH] perf stat: Align CSV output for summary mode

2021-03-16 Thread Jin Yao
perf-stat has supported the summary mode. But the summary lines break the CSV output so it's hard for scripts to parse the result. Before: # perf stat -x, -I1000 --interval-count 1 --summary 1.001323097,8013.48,msec,cpu-clock,8013483384,100.00,8.013,CPUs utilized 1.001323097,270,,