Re: Re: [PATCH] perf probe: Fix --line option behavior

2014-04-01 Thread Masami Hiramatsu
(2014/04/01 16:21), Namhyung Kim wrote: > Hi Masami, > > (Also adding Jiri in CC and changing email of acme) > > On Tue, Apr 1, 2014 at 5:01 AM, Masami Hiramatsu > wrote: >> (2014/04/01 13:47), Namhyung Kim wrote: >>> The commit 5a62257a3ddd1 ("perf probe: Replace line_list with >>> intlist") re

Re: [PATCH] perf probe: Fix --line option behavior

2014-04-01 Thread Namhyung Kim
Hi Masami, (Also adding Jiri in CC and changing email of acme) On Tue, Apr 1, 2014 at 5:01 AM, Masami Hiramatsu wrote: > (2014/04/01 13:47), Namhyung Kim wrote: >> The commit 5a62257a3ddd1 ("perf probe: Replace line_list with >> intlist") replaced line_list to intlist but it has a problem that i

[PATCH] perf probe: Fix --line option behavior

2014-03-31 Thread Namhyung Kim
The commit 5a62257a3ddd1 ("perf probe: Replace line_list with intlist") replaced line_list to intlist but it has a problem that if a same line was added again, it'd return -EEXIST rather than 1. Since line_range_walk_cb() only checks the result being negative, it resulted in failure or segfault so

Re: [PATCH] perf probe: Fix --line option behavior

2014-03-31 Thread Masami Hiramatsu
(2014/04/01 13:47), Namhyung Kim wrote: > The commit 5a62257a3ddd1 ("perf probe: Replace line_list with > intlist") replaced line_list to intlist but it has a problem that if a > same line was added again, it'd return -EEXIST rather than 1. Ah, right! that's a different behavior. > Since line_ran