Re: [PATCH] perf ordered_events: Optimise event object reuse

2020-05-21 Thread Matt Fleming
On Wed, 20 May, at 11:52:34PM, Jiri Olsa wrote: > On Wed, May 20, 2020 at 02:00:49PM +0100, Matt Fleming wrote: > > > > Nope, the tests in this file are unit tests so I'm testing > > free_cache_{get,put} which are file-local functions by #include'ing > > ordered-events.c. > > > > The above defin

Re: [PATCH] perf ordered_events: Optimise event object reuse

2020-05-20 Thread Jiri Olsa
On Wed, May 20, 2020 at 02:00:49PM +0100, Matt Fleming wrote: > On Mon, 18 May, at 02:04:08PM, Jiri Olsa wrote: > > On Fri, May 15, 2020 at 10:01:51PM +0100, Matt Fleming wrote: > > > ordered_event objects can be placed on the free object cache list in any > > > order which means future allocations

Re: [PATCH] perf ordered_events: Optimise event object reuse

2020-05-20 Thread Matt Fleming
On Mon, 18 May, at 02:04:08PM, Jiri Olsa wrote: > On Fri, May 15, 2020 at 10:01:51PM +0100, Matt Fleming wrote: > > ordered_event objects can be placed on the free object cache list in any > > order which means future allocations may not return objects at > > sequential locations in memory. Getting

Re: [PATCH] perf ordered_events: Optimise event object reuse

2020-05-18 Thread Jiri Olsa
On Fri, May 15, 2020 at 10:01:51PM +0100, Matt Fleming wrote: > ordered_event objects can be placed on the free object cache list in any > order which means future allocations may not return objects at > sequential locations in memory. Getting non-contiguous objects from the > free cache has bad co

[PATCH] perf ordered_events: Optimise event object reuse

2020-05-15 Thread Matt Fleming
ordered_event objects can be placed on the free object cache list in any order which means future allocations may not return objects at sequential locations in memory. Getting non-contiguous objects from the free cache has bad consequences when later iterating over those objects in ordered_events__