Jiri Olsa wrote:
> but looks like the usage is for bash completion only, so we probably
> need only the first example functionality above.
>
> If this is the case I think it should not be an option but another
> command like 'raw-dump'.
I decided that there's no point making it an option, so I've
On Thu, Mar 27, 2014 at 05:27:41PM -0400, Ramkumar Ramachandra wrote:
> While adding usage information, 44d742e (perf list: Add usage,
> 2013-10-30) broke
>
> $ perf list --raw-dump
>
> Fix this by making raw-dump a proper argument.
>
> Cc: David Ahern
> Cc: Jiri Olsa
> Cc: Arnaldo Carvalho
While adding usage information, 44d742e (perf list: Add usage,
2013-10-30) broke
$ perf list --raw-dump
Fix this by making raw-dump a proper argument.
Cc: David Ahern
Cc: Jiri Olsa
Cc: Arnaldo Carvalho de Melo
Signed-off-by: Ramkumar Ramachandra
---
I sent this patch earlier, but it didn'
On 12/29/2013 05:11 AM, Ramkumar Ramachandra wrote:
Arnaldo Carvalho de Melo wrote:
So is the patch below the one to apply? When these things happen, it
helps if you resubmit with a v2 in the subject line and then an explicit
Ack is provided, be it from, in this case, David, or Ramkumar could ju
Arnaldo Carvalho de Melo wrote:
> So is the patch below the one to apply? When these things happen, it
> helps if you resubmit with a v2 in the subject line and then an explicit
> Ack is provided, be it from, in this case, David, or Ramkumar could just
> add it since David provided it in free form,
t to
> work.
> From 7198a494cfef43395e8683ac3a0576277b8d1d80 Mon Sep 17 00:00:00 2001
> From: David Ahern
> Date: Wed, 11 Dec 2013 14:00:20 -0700
> Subject: [PATCH] perf list: Fix raw-dump arg
>
> Ramkumar reported that perf list --raw-dump was broken by 44d742e.
> Fi
ed, 11 Dec 2013 14:00:20 -0700
Subject: [PATCH] perf list: Fix raw-dump arg
Ramkumar reported that perf list --raw-dump was broken by 44d742e.
Fix by making raw-dump a proper option.
Signed-off-by: David Ahern
Signed-off-by: Dongsheng Yang
Cc: Ingo Molnar
Cc: Arnaldo Carvalho de Melo
Cc: Ra
On 12/12/13, 12:34 AM, Ramkumar Ramachandra wrote:
David Ahern wrote:
Why not make raw_dump a proper argument?
Sure, that'd work too. I was thinking of a minimal way to fix the
problem myself.
diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
index 011195e38f21..b553d0c4ca82
}
This won't work because you've put it right below the `if (argc ==
0)`, which executes print_events(). You could move it up and get it to
work.
From 7198a494cfef43395e8683ac3a0576277b8d1d80 Mon Sep 17 00:00:00 2001
From: David Ahern
Date: Wed, 11 Dec 2013 14:00:20 -0700
Subject:
Mon Sep 17 00:00:00 2001
From: David Ahern
Date: Wed, 11 Dec 2013 14:00:20 -0700
Subject: [PATCH] perf list: Fix raw-dump arg
Ramkumar reported that perf list --raw-dump was broken by 44d742e.
Fix by making raw-dump a proper argument.
Signed-off-by: David Ahern
Cc: Ingo Molnar
Cc: Arnaldo Carva
While adding usage information, 44d742e (perf list: Add usage,
2013-10-30) broke
$ perf list --raw-dump
by asking parse_options() to stop at
non-option (PARSE_OPT_STOP_AT_NON_OPTION), hence parsing the option
--raw-dump and barfing. Ask it to keep unknown options
unparsed (PARSE_OPT_KEEP_UNKNOW
11 matches
Mail list logo
