Re: [PATCH] perf headers: fix processing of pmu_mappings

2020-06-09 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 08, 2020 at 09:52:43AM -0700, Ian Rogers escreveu: > On Mon, Jun 8, 2020 at 9:18 AM Stephane Eranian wrote: > > This patch fixes a bug in process_pmu_mappings() where the code > > would not produce an env->pmu_mappings string that was easily parsable. > > The function parses the PMU_MA

Re: [PATCH] perf headers: fix processing of pmu_mappings

2020-06-09 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 08, 2020 at 09:52:43AM -0700, Ian Rogers escreveu: > On Mon, Jun 8, 2020 at 9:18 AM Stephane Eranian wrote: > A lot of the complexity in this code came from strbuf not \0 > terminating strings. Would a strbuf that always \0 terminated be a > useful change? In general there's a lack of

Re: [PATCH] perf headers: fix processing of pmu_mappings

2020-06-08 Thread Ian Rogers
On Mon, Jun 8, 2020 at 9:18 AM Stephane Eranian wrote: > > This patch fixes a bug in process_pmu_mappings() where the code > would not produce an env->pmu_mappings string that was easily parsable. > The function parses the PMU_MAPPING header information into a string > consisting of value:name pai

[PATCH] perf headers: fix processing of pmu_mappings

2020-06-08 Thread Stephane Eranian
This patch fixes a bug in process_pmu_mappings() where the code would not produce an env->pmu_mappings string that was easily parsable. The function parses the PMU_MAPPING header information into a string consisting of value:name pairs where value is the PMU type identifier and name is the PMU name