Re: [PATCH] perf: report: don't allow empty argument for '-t'.

2015-03-19 Thread Namhyung Kim
Hi Arnaldo, On Thu, Mar 19, 2015 at 11:00 PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Mar 19, 2015 at 04:26:24PM +0900, Namhyung Kim escreveu: >> On Thu, Mar 19, 2015 at 02:41:42PM +0800, Wang Nan wrote: >> > Hi Namhyung Kim, >> >> Hello, >> >> > >> > Do you have any comment on it? >> >> As I s

Re: [PATCH] perf: report: don't allow empty argument for '-t'.

2015-03-19 Thread Arnaldo Carvalho de Melo
Em Thu, Mar 19, 2015 at 04:26:24PM +0900, Namhyung Kim escreveu: > On Thu, Mar 19, 2015 at 02:41:42PM +0800, Wang Nan wrote: > > Hi Namhyung Kim, > > Hello, > > > > > Do you have any comment on it? > > As I said in previous reply, I think perf 'diff' and 'mem' have same > problem. So how about

Re: [PATCH] perf: report: don't allow empty argument for '-t'.

2015-03-19 Thread Namhyung Kim
On Thu, Mar 19, 2015 at 02:41:42PM +0800, Wang Nan wrote: > Hi Namhyung Kim, Hello, > > Do you have any comment on it? As I said in previous reply, I think perf 'diff' and 'mem' have same problem. So how about fix them altogether? Thanks, Namhyung > > Thank you. > > On 2015/3/13 20:51, Wa

Re: [PATCH] perf: report: don't allow empty argument for '-t'.

2015-03-18 Thread Wang Nan
Hi Namhyung Kim, Do you have any comment on it? Thank you. On 2015/3/13 20:51, Wang Nan wrote: > Without this patch, perf report cause segfault if pass "" as '-t': > > $ perf report -t "" > ># To display the perf.data header info, please use --header/--header-only > options. ># >

Re: [PATCH] perf: report: don't allow empty argument for '-t'.

2015-03-15 Thread Namhyung Kim
On Fri, Mar 13, 2015 at 12:51:54PM +, Wang Nan wrote: > Without this patch, perf report cause segfault if pass "" as '-t': > > $ perf report -t "" > ># To display the perf.data header info, please use --header/--header-only > options. ># ># Samples: 37 of event 'syscalls:sys_e

[PATCH] perf: report: don't allow empty argument for '-t'.

2015-03-13 Thread Wang Nan
Without this patch, perf report cause segfault if pass "" as '-t': $ perf report -t "" # To display the perf.data header info, please use --header/--header-only options. # # Samples: 37 of event 'syscalls:sys_enter_write' # Event count (approx.): 37 # # ChildrenSelfComma