Re: [PATCH] perf: Remove unneeded include

2013-11-06 Thread Namhyung Kim
Hi Rodrigo, On Wed, 6 Nov 2013 22:20:54 +, Rodrigo Campos wrote: > There is no point in sort.h including itself. > > The include was added when the file was created, in commit "perf tools: Create > util/sort.and use it" (dd68ada2d) and added a include to "sort.h" in lot of > files (all the fi

[PATCH] perf: Remove unneeded include

2013-11-06 Thread Rodrigo Campos
There is no point in sort.h including itself. The include was added when the file was created, in commit "perf tools: Create util/sort.and use it" (dd68ada2d) and added a include to "sort.h" in lot of files (all the files that started using the file). It was probably added by mistake on sort.h too

Re: [PATCH] perf: remove unneeded include of network header files

2012-09-05 Thread David Ahern
On 9/5/12 4:37 PM, Arnaldo Carvalho de Melo wrote: I fixed it already, nevermind, it was just a matter of reordering includes, think how fragil that is, but it works now. tried that route too. I could not figure out the magic ordering, so punted on v2 of the patch leaving netdb.h in. Glad to

Re: [PATCH] perf: remove unneeded include of network header files

2012-09-05 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 05, 2012 at 03:53:06PM -0600, David Ahern escreveu: > perf does not have networking related functionality, and the inclusion of > these headers is one of the causes of compile failures for Android: > https://lkml.org/lkml/2012/8/23/316 > https://lkml.org/lkml/2012/8/28/293 > > So,

Re: [PATCH] perf: remove unneeded include of network header files

2012-09-05 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 05, 2012 at 03:18:03PM -0600, David Ahern escreveu: > On 9/5/12 2:39 PM, Arnaldo Carvalho de Melo wrote: > >Em Wed, Aug 29, 2012 at 09:55:32AM -0600, David Ahern escreveu: > >>perf does not have networking related functionality, and the inclusion of > >>these headers is one of the cause

[PATCH] perf: remove unneeded include of network header files

2012-09-05 Thread David Ahern
perf does not have networking related functionality, and the inclusion of these headers is one of the causes of compile failures for Android: https://lkml.org/lkml/2012/8/23/316 https://lkml.org/lkml/2012/8/28/293 So, remove them. v2: - netdb.h is required by trace-event-perl.c, so leave it i

Re: [PATCH] perf: remove unneeded include of network header files

2012-09-05 Thread David Ahern
On 9/5/12 2:39 PM, Arnaldo Carvalho de Melo wrote: Em Wed, Aug 29, 2012 at 09:55:32AM -0600, David Ahern escreveu: perf does not have networking related functionality, and the inclusion of these headers is one of the causes of compile failures for Android: https://lkml.org/lkml/2012/8/23/316

Re: [PATCH] perf: remove unneeded include of network header files

2012-09-05 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 29, 2012 at 09:55:32AM -0600, David Ahern escreveu: > perf does not have networking related functionality, and the inclusion of > these headers is one of the causes of compile failures for Android: > https://lkml.org/lkml/2012/8/23/316 > https://lkml.org/lkml/2012/8/28/293 > > So,

[PATCH] perf: remove unneeded include of network header files

2012-08-29 Thread David Ahern
perf does not have networking related functionality, and the inclusion of these headers is one of the causes of compile failures for Android: https://lkml.org/lkml/2012/8/23/316 https://lkml.org/lkml/2012/8/28/293 So, remove them. Signed-off-by: David Ahern Cc: Ingo Molnar Cc: Frederic Weis