Re: [PATCH] perf/script: remove extraneous newline in perf_sample__fprintf_regs()

2020-04-29 Thread Stephane Eranian
On Wed, Apr 29, 2020 at 7:09 PM Andi Kleen wrote: > > > I was under the impression that perf script was generating one line > > per sample. Otherwise, seems hard to parse. > > That's only true for simple cases. A lot of the extended output options > have long generated multiple lines. And of cours

Re: [PATCH] perf/script: remove extraneous newline in perf_sample__fprintf_regs()

2020-04-29 Thread Andi Kleen
> I was under the impression that perf script was generating one line > per sample. Otherwise, seems hard to parse. That's only true for simple cases. A lot of the extended output options have long generated multiple lines. And of course call stacks always did. > Could you give me the cmdline opt

Re: [PATCH] perf/script: remove extraneous newline in perf_sample__fprintf_regs()

2020-04-29 Thread Stephane Eranian
On Mon, Apr 27, 2020 at 7:47 PM Andi Kleen wrote: > > On Sat, Apr 18, 2020 at 04:19:08PM -0700, Stephane Eranian wrote: > > When printing iregs, there was a double newline printed because > > perf_sample__fprintf_regs() was printing its own and then at the > > end of all fields, perf script was ad

Re: [PATCH] perf/script: remove extraneous newline in perf_sample__fprintf_regs()

2020-04-28 Thread Arnaldo Carvalho de Melo
Em Mon, Apr 27, 2020 at 02:43:28PM -0700, Stephane Eranian escreveu: > On Sat, Apr 18, 2020 at 4:19 PM Stephane Eranian wrote: > > > > When printing iregs, there was a double newline printed because > > perf_sample__fprintf_regs() was printing its own and then at the > > end of all fields, perf sc