Re: [PATCH] perf/report: [RFC] Handling OOM in perf report

2019-04-15 Thread Jiri Olsa
On Wed, Apr 10, 2019 at 09:17:30AM +0200, Thomas-Mich Richter wrote: SNIP > > > > > > --- > > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c > > index b17f1c9bc965..eea247a26ad8 100644 > > --- a/tools/perf/util/session.c > > +++ b/tools/perf/util/session.c > > @@ -1933,7 +19

Re: [PATCH] perf/report: [RFC] Handling OOM in perf report

2019-04-10 Thread Thomas-Mich Richter
On 4/9/19 12:42 PM, Jiri Olsa wrote: > On Mon, Apr 01, 2019 at 04:20:00PM +0200, Thomas Richter wrote: > > SNIP > >> perf_session__process_event() returns to its caller, where -ENOMEM is >> changed to -EINVAL and processing stops: >> >> if ((skip = perf_session__process_event(session, event, hea

Re: [PATCH] perf/report: [RFC] Handling OOM in perf report

2019-04-09 Thread Jiri Olsa
On Mon, Apr 01, 2019 at 04:20:00PM +0200, Thomas Richter wrote: SNIP > perf_session__process_event() returns to its caller, where -ENOMEM is > changed to -EINVAL and processing stops: > > if ((skip = perf_session__process_event(session, event, head)) < 0) { > pr_err("%#" PRIx64 " [%#x]: f

[PATCH] perf/report: [RFC] Handling OOM in perf report

2019-04-01 Thread Thomas Richter
A very strange -ENOMEM error which only when output is displayed using the GTK GUI (I have copied the text from the GUI): [root@m35lp76 perf]# ./perf report -i perf.data.error68-1 Processing events... [974K/3M] Error:failed to process sample 0xf4198 [0x8]: failed to proc