Re: [PATCH] perf/aux: Only update aux_wakeup in non-overwrite mode

2017-09-28 Thread Peter Zijlstra
On Thu, Sep 28, 2017 at 12:29:15PM +0100, Will Deacon wrote: > What's the status on this patch? I don't see it in mainline or linux-next, > but it would ideally get in as a fix for 4.14. Its in the patch queue I'm trying to get mingo to merge ;-) It is indeed queued for /urgent.

Re: [PATCH] perf/aux: Only update aux_wakeup in non-overwrite mode

2017-09-28 Thread Will Deacon
Hi Alexander, On Wed, Sep 13, 2017 at 01:34:03PM +0300, Alexander Shishkin wrote: > Will Deacon writes: > > On Wed, Sep 06, 2017 at 07:08:11PM +0300, Alexander Shishkin wrote: > >> Commit d9a50b0256 ("perf/aux: Ensure aux_wakeup represents most recent > >> wakeup index") changed aux wakeup positi

Re: [PATCH] perf/aux: Only update aux_wakeup in non-overwrite mode

2017-09-13 Thread Alexander Shishkin
Will Deacon writes: > Hi Alexander, > > On Wed, Sep 06, 2017 at 07:08:11PM +0300, Alexander Shishkin wrote: >> Commit d9a50b0256 ("perf/aux: Ensure aux_wakeup represents most recent >> wakeup index") changed aux wakeup position calculation to rounddown(), >> which causes a division-by-zero in AUX

Re: [PATCH] perf/aux: Only update aux_wakeup in non-overwrite mode

2017-09-12 Thread Will Deacon
Hi Alexander, On Wed, Sep 06, 2017 at 07:08:11PM +0300, Alexander Shishkin wrote: > Commit d9a50b0256 ("perf/aux: Ensure aux_wakeup represents most recent > wakeup index") changed aux wakeup position calculation to rounddown(), > which causes a division-by-zero in AUX overwrite mode (aka "snapshot

[PATCH] perf/aux: Only update aux_wakeup in non-overwrite mode

2017-09-06 Thread Alexander Shishkin
Commit d9a50b0256 ("perf/aux: Ensure aux_wakeup represents most recent wakeup index") changed aux wakeup position calculation to rounddown(), which causes a division-by-zero in AUX overwrite mode (aka "snapshot mode"). The zero denominator results from the fact that perf record doesn't set aux_wat