Re: [PATCH] perf, tools: Improve error messages for missing PMUs

2017-09-15 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 15, 2017 at 08:45:10PM +0200, Jiri Olsa escreveu: > On Wed, Sep 13, 2017 at 02:50:06PM -0700, Andi Kleen wrote: > > +++ b/tools/perf/util/metricgroup.c > > @@ -477,7 +477,7 @@ int metricgroup__parse_groups(const struct option *opt, > > memset(&parse_error, 0, sizeof(struct parse_eve

Re: [PATCH] perf, tools: Improve error messages for missing PMUs

2017-09-15 Thread Jiri Olsa
On Wed, Sep 13, 2017 at 02:50:06PM -0700, Andi Kleen wrote: > From: Andi Kleen > > When a PMU is missing print a better error message mentioning > the missing PMU. > > % mkdir empty > % mount --bind empty /sys/devices/msr > % perf stat -M Summary true > event syntax error: > '{inst_retired.any,

[PATCH] perf, tools: Improve error messages for missing PMUs

2017-09-13 Thread Andi Kleen
From: Andi Kleen When a PMU is missing print a better error message mentioning the missing PMU. % mkdir empty % mount --bind empty /sys/devices/msr % perf stat -M Summary true event syntax error: '{inst_retired.any,cycles}:W,{cpu_clk_unhalted.thread}:W,{inst_retired.any}:W,{cpu_clk_unhalted.ref

Re: [PATCH] perf, tools: Improve error messages for missing PMUs

2017-09-13 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 11, 2017 at 05:26:36PM -0700, Andi Kleen escreveu: > From: Andi Kleen > > When a PMU is missing print a better error message mentioning > the missing PMU. > > % mkdir empty > % mount --bind empty /sys/devices/msr > % perf stat -M Summary true > event syntax error: > '{inst_retired.a

[PATCH] perf, tools: Improve error messages for missing PMUs

2017-09-11 Thread Andi Kleen
From: Andi Kleen When a PMU is missing print a better error message mentioning the missing PMU. % mkdir empty % mount --bind empty /sys/devices/msr % perf stat -M Summary true event syntax error: '{inst_retired.any,cycles}:W,{cpu_clk_unhalted.thread}:W,{inst_retired.any}:W,{cpu_clk_unhalted.ref