Re: [PATCH] pciehp: Fix race condition handling surprise link-down

2017-03-09 Thread Bjorn Helgaas
On Wed, Mar 08, 2017 at 04:27:26AM -0800, Raj, Ashok wrote: > On Mon, Mar 06, 2017 at 06:24:17PM -0600, Bjorn Helgaas wrote: > > On Fri, Feb 03, 2017 at 10:51:04AM -0600, Bjorn Helgaas wrote: > > > > Hi Ashok, > > > > Just a ping to make sure we're not deadlocked. I'm waiting for you, > > so I h

Re: [PATCH] pciehp: Fix race condition handling surprise link-down

2017-03-08 Thread Raj, Ashok
On Mon, Mar 06, 2017 at 06:24:17PM -0600, Bjorn Helgaas wrote: > On Fri, Feb 03, 2017 at 10:51:04AM -0600, Bjorn Helgaas wrote: > > Hi Ashok, > > Just a ping to make sure we're not deadlocked. I'm waiting for you, > so I hope you're not also waiting for me :) I'm not trying to rush you; > I jus

Re: [PATCH] pciehp: Fix race condition handling surprise link-down

2017-03-06 Thread Bjorn Helgaas
On Fri, Feb 03, 2017 at 10:51:04AM -0600, Bjorn Helgaas wrote: > On Thu, Feb 02, 2017 at 10:00:53PM -0800, Raj, Ashok wrote: > > ... > > Just to summarize, we only queue the POWEROFF due to surprise link down > > and another POWERON due to link becoming back up. The transient link-down > > events

Re: [PATCH] pciehp: Fix race condition handling surprise link-down

2017-02-03 Thread Bjorn Helgaas
On Thu, Feb 02, 2017 at 10:00:53PM -0800, Raj, Ashok wrote: > Hi Bjorn > > On Thu, Feb 02, 2017 at 08:59:01PM -0600, Bjorn Helgaas wrote: > > Hi Ashok, > > > > Sorry it took me so long to review this. I never felt like I really > > understood it, and it took me a long time to try to figure out a

Re: [PATCH] pciehp: Fix race condition handling surprise link-down

2017-02-02 Thread Raj, Ashok
Hi Bjorn On Thu, Feb 02, 2017 at 08:59:01PM -0600, Bjorn Helgaas wrote: > Hi Ashok, > > Sorry it took me so long to review this. I never felt like I really > understood it, and it took me a long time to try to figure out a more > useful response. No worries. Agree its a litte tricky, and took m

Re: [PATCH] pciehp: Fix race condition handling surprise link-down

2017-02-02 Thread Bjorn Helgaas
Hi Ashok, Sorry it took me so long to review this. I never felt like I really understood it, and it took me a long time to try to figure out a more useful response. On Fri, Dec 09, 2016 at 01:06:04PM -0800, Ashok Raj wrote: > Changes from v1: > Address comments from Bjorn: >

Re: [PATCH] pciehp: Fix race condition handling surprise link-down

2017-01-19 Thread Bjorn Helgaas
Sorry for the delay, I'm just trying to clear out some of our defects from bugzilla and have gotten really behind on the list, so I just haven't gotten to this yet. On Wed, Jan 18, 2017 at 01:47:11PM -0500, Keith Busch wrote: > Hi Bjorn, > > This fix looks good to me as well now. Any other concer

Re: [PATCH] pciehp: Fix race condition handling surprise link-down

2017-01-18 Thread Keith Busch
Hi Bjorn, This fix looks good to me as well now. Any other concerns before staging this one for inclusion? Thanks, Keith On Tue, Jan 17, 2017 at 11:15:40AM -0800, Raj, Ashok wrote: > Hi Bjorn > > Sorry to bug you, didn't hear from you after i added the lock for consistency > to address the feed

Re: [PATCH] pciehp: Fix race condition handling surprise link-down

2017-01-17 Thread Raj, Ashok
Hi Bjorn Sorry to bug you, didn't hear from you after i added the lock for consistency to address the feedback. Let me know if there is anymore changes you like to see. Cheers, Ashok On Fri, Dec 09, 2016 at 01:06:04PM -0800, Ashok Raj wrote: > Changes from v1: > Address comments from Bjor

Re: [PATCH] pciehp: Fix race condition handling surprise link-down

2017-01-11 Thread Raj, Ashok
Hi Keith did you have a chance to look at this? Cheers, Ashok On Fri, Dec 09, 2016 at 01:06:04PM -0800, Ashok Raj wrote: > Changes from v1: > Address comments from Bjorn: > Added p_slot->lock mutex around changes to p_slot->state > Updated commit message to call

[PATCH] pciehp: Fix race condition handling surprise link-down

2016-12-09 Thread Ashok Raj
Changes from v1: Address comments from Bjorn: Added p_slot->lock mutex around changes to p_slot->state Updated commit message to call out mutex names A surprise link down may retrain very quickly, causing the same slot to generate a link up event before hand