Re: [PATCH] pci/pciehp: bail on bogus pcie reads from removed devices

2015-08-04 Thread Bjorn Helgaas
On Tue, Aug 4, 2015 at 3:22 PM, Jarod Wilson wrote: > On 8/4/2015 3:27 PM, Bjorn Helgaas wrote: >> >> On Tue, Aug 4, 2015 at 1:46 PM, Jarod Wilson wrote: >>> >>> On 8/4/2015 1:51 PM, Bjorn Helgaas wrote: > > ... > >> Can you try the version I posted, with the additional tests in >> pcie_p

Re: [PATCH] pci/pciehp: bail on bogus pcie reads from removed devices

2015-08-04 Thread Jarod Wilson
On 8/4/2015 3:27 PM, Bjorn Helgaas wrote: On Tue, Aug 4, 2015 at 1:46 PM, Jarod Wilson wrote: On 8/4/2015 1:51 PM, Bjorn Helgaas wrote: ... Can you try the version I posted, with the additional tests in pcie_poll_cmd() and pcie_do_write_cmd()? We should try to read from the device there, eve

Re: [PATCH] pci/pciehp: bail on bogus pcie reads from removed devices

2015-08-04 Thread Bjorn Helgaas
On Tue, Aug 4, 2015 at 1:46 PM, Jarod Wilson wrote: > On 8/4/2015 1:51 PM, Bjorn Helgaas wrote: >> >> On Tue, Aug 04, 2015 at 01:21:23PM -0400, Jarod Wilson wrote: >>> >>> On 8/4/2015 12:56 PM, Bjorn Helgaas wrote: On Tue, Aug 04, 2015 at 10:05:18AM -0400, Jarod Wilson wrote: > >

Re: [PATCH] pci/pciehp: bail on bogus pcie reads from removed devices

2015-08-04 Thread Jarod Wilson
On 8/4/2015 1:51 PM, Bjorn Helgaas wrote: On Tue, Aug 04, 2015 at 01:21:23PM -0400, Jarod Wilson wrote: On 8/4/2015 12:56 PM, Bjorn Helgaas wrote: On Tue, Aug 04, 2015 at 10:05:18AM -0400, Jarod Wilson wrote: On Mon, Aug 3, 2015 at 12:14 AM, Bjorn Helgaas wrote: On Tue, Jul 21, 2015 at 12:2

Re: [PATCH] pci/pciehp: bail on bogus pcie reads from removed devices

2015-08-04 Thread Bjorn Helgaas
On Tue, Aug 04, 2015 at 01:21:23PM -0400, Jarod Wilson wrote: > On 8/4/2015 12:56 PM, Bjorn Helgaas wrote: > >On Tue, Aug 04, 2015 at 10:05:18AM -0400, Jarod Wilson wrote: > >>On Mon, Aug 3, 2015 at 12:14 AM, Bjorn Helgaas wrote: > >> > >>>On Tue, Jul 21, 2015 at 12:25:30PM -0400, Jarod Wilson wro

Re: [PATCH] pci/pciehp: bail on bogus pcie reads from removed devices

2015-08-04 Thread Jarod Wilson
On 8/4/2015 12:56 PM, Bjorn Helgaas wrote: On Tue, Aug 04, 2015 at 10:05:18AM -0400, Jarod Wilson wrote: On Mon, Aug 3, 2015 at 12:14 AM, Bjorn Helgaas wrote: On Tue, Jul 21, 2015 at 12:25:30PM -0400, Jarod Wilson wrote: https://bugzilla.kernel.org/show_bug.cgi?id=99841 Seems like a read of

Re: [PATCH] pci/pciehp: bail on bogus pcie reads from removed devices

2015-08-04 Thread Bjorn Helgaas
On Tue, Aug 04, 2015 at 10:05:18AM -0400, Jarod Wilson wrote: > On Mon, Aug 3, 2015 at 12:14 AM, Bjorn Helgaas wrote: > > > On Tue, Jul 21, 2015 at 12:25:30PM -0400, Jarod Wilson wrote: > > > https://bugzilla.kernel.org/show_bug.cgi?id=99841 > > > > > > Seems like a read of all 1's from a registe

Re: [PATCH] pci/pciehp: bail on bogus pcie reads from removed devices

2015-08-04 Thread Jarod Wilson
Re-sending, hopefully without multi-part now, so it gets to the list. Temporarily forced into using a different mail client... On Tue, Aug 4, 2015 at 10:05 AM, Jarod Wilson wrote: > On Mon, Aug 3, 2015 at 12:14 AM, Bjorn Helgaas wrote: >> >> On Tue, Jul 21, 2015 at 12:25:30PM -0400, Jarod Wilson

Re: [PATCH] pci/pciehp: bail on bogus pcie reads from removed devices

2015-08-02 Thread Bjorn Helgaas
On Tue, Jul 21, 2015 at 12:25:30PM -0400, Jarod Wilson wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=99841 > > Seems like a read of all 1's from a register of a device that has gone > away should be taken as a sign that the device has gone away. > Section 6.2.10 of the PCIE spec (v4.0, rev

[PATCH] pci/pciehp: bail on bogus pcie reads from removed devices

2015-07-21 Thread Jarod Wilson
https://bugzilla.kernel.org/show_bug.cgi?id=99841 Seems like a read of all 1's from a register of a device that has gone away should be taken as a sign that the device has gone away. Section 6.2.10 of the PCIE spec (v4.0, rev 0.3, Feb 19, 2014) suggests as much with this snippet: |IMPLEMENTATION