Alan Cox wrote:
+if (t.active > 16)
+t.active = 16;
Erm, clamping active time is not a right thing to do. Right thing to do
was to bail out. I didn't do it in the legacy driver rewrite though...
As far as I can work out its a "can't happen"
+pci_read_config_byte(pd
> >> +if (t.active > 16)
> >> +t.active = 16;
>
> Erm, clamping active time is not a right thing to do. Right thing to do
> was to bail out. I didn't do it in the legacy driver rewrite though...
As far as I can work out its a "can't happen"
> >> +pci_read_config_byte(pde
Hello.
Jeff Garzik wrote:
+/* The second channel has shared timings and the setup timing is
+ messy to switch to merge it for worst case */
+if (ap->port_no && pair) {
+struct ata_timing p;
+ata_timing_compute(pair, pair->pio_mode, &p, T, 1);
+ata_timing_me
> > + if (ap->port_no != 0 && adev->devno != timing->last) {
> > + pci_write_config_byte(pdev, DRWTIM23,
> > timing->reg58[adev->devno]);
> > + timing->last = adev->devno;
> > + }
>
> It might be worth looking into whether ->dev_select is a better place
> for this sort of
Alan Cox wrote:
Support for the PCI CMD640 (not VLB)
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
Overall ACK, with minor comments/questions below
Not applying (yet) due to cable_detect dependency. will await resend
once dependency is satisfied.
+static void cmd640_set_piomode(struct ata
Support for the PCI CMD640 (not VLB)
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.21-rc2/drivers/ata/Kconfig
linux-2.6.21-rc2/drivers/ata/Kconfig
--- linux.vanilla-2.6.21-rc2/drivers/ata/Kconfig2007-03-01
1
6 matches
Mail list logo
