Re: [PATCH] param: do not set store func without write perm

2014-12-11 Thread Rusty Russell
Kees Cook writes: > When a module_param is defined without DAC write permissions, it can > still be changed at runtime and updated. Drivers using a 0444 permission > may be surprised that these values can still be changed. > > For drivers that want to allow updates, any S_IW* flag will set the > "

[PATCH] param: do not set store func without write perm

2014-12-11 Thread Kees Cook
When a module_param is defined without DAC write permissions, it can still be changed at runtime and updated. Drivers using a 0444 permission may be surprised that these values can still be changed. For drivers that want to allow updates, any S_IW* flag will set the "store" function as before. Dri