Re: [PATCH] osd fs: __r4w_get_page rely on PageUptodate for uptodate

2015-11-03 Thread Hugh Dickins
On Tue, 3 Nov 2015, Boaz Harrosh wrote: > On 11/03/2015 04:49 AM, Hugh Dickins wrote: > > On Mon, 2 Nov 2015, Boaz Harrosh wrote: > >> > >> Do you think the code is actually wrong as is? > > > > Not that I know of: just a little too complicated and confusing. > > > > But becomes slightly wrong if

Re: [PATCH] osd fs: __r4w_get_page rely on PageUptodate for uptodate

2015-11-03 Thread Boaz Harrosh
On 11/03/2015 04:49 AM, Hugh Dickins wrote: > On Mon, 2 Nov 2015, Boaz Harrosh wrote: >> On 11/02/2015 01:39 AM, Hugh Dickins wrote: >> <> This patch is not correct! >>> >>> I think you have actually confirmed that the patch is correct: >>> why bother to test PageDirty or PageWriteback when Pa

Re: [PATCH] osd fs: __r4w_get_page rely on PageUptodate for uptodate

2015-11-02 Thread Hugh Dickins
On Mon, 2 Nov 2015, Boaz Harrosh wrote: > On 11/02/2015 01:39 AM, Hugh Dickins wrote: > <> > >> This patch is not correct! > > > > I think you have actually confirmed that the patch is correct: > > why bother to test PageDirty or PageWriteback when PageUptodate > > already tells you what you need?

Re: [PATCH] osd fs: __r4w_get_page rely on PageUptodate for uptodate

2015-11-02 Thread Boaz Harrosh
On 11/02/2015 01:39 AM, Hugh Dickins wrote: <> >> This patch is not correct! > > I think you have actually confirmed that the patch is correct: > why bother to test PageDirty or PageWriteback when PageUptodate > already tells you what you need? > > Or do these filesystems do something unusual wit

Re: [PATCH] osd fs: __r4w_get_page rely on PageUptodate for uptodate

2015-11-01 Thread Hugh Dickins
On Sun, 1 Nov 2015, Boaz Harrosh wrote: > On 10/29/2015 08:43 PM, Hugh Dickins wrote: > > Patch "mm: migrate dirty page without clear_page_dirty_for_io etc", > > presently staged in mmotm and linux-next, simplifies the migration of > > a PageDirty pagecache page: one stat needs moving from zone to

Re: [PATCH] osd fs: __r4w_get_page rely on PageUptodate for uptodate

2015-11-01 Thread Boaz Harrosh
On 10/29/2015 08:43 PM, Hugh Dickins wrote: > Patch "mm: migrate dirty page without clear_page_dirty_for_io etc", > presently staged in mmotm and linux-next, simplifies the migration of > a PageDirty pagecache page: one stat needs moving from zone to zone > and that's about all. > > It's convenien

[PATCH] osd fs: __r4w_get_page rely on PageUptodate for uptodate

2015-10-29 Thread Hugh Dickins
Patch "mm: migrate dirty page without clear_page_dirty_for_io etc", presently staged in mmotm and linux-next, simplifies the migration of a PageDirty pagecache page: one stat needs moving from zone to zone and that's about all. It's convenient and safest for it to shift the PageDirty bit from old