Re: [PATCH] of: unittest: Don't dereference args.np after test errors

2018-09-24 Thread Guenter Roeck
Hi Frank, On 09/24/2018 09:19 PM, Frank Rowand wrote: Hi Guenter, On 09/23/18 09:33, Guenter Roeck wrote: If a devicetree parse function fails, it is quite likely that args.np is invalid. Trying to dereference it will then cause the system to crash. This was seen when trying to run devicetree

Re: [PATCH] of: unittest: Don't dereference args.np after test errors

2018-09-24 Thread Frank Rowand
On 09/24/18 21:19, Frank Rowand wrote: > Hi Guenter, > > On 09/23/18 09:33, Guenter Roeck wrote: >> If a devicetree parse function fails, it is quite likely that args.np >> is invalid. Trying to dereference it will then cause the system to crash. >> >> This was seen when trying to run devicetree u

Re: [PATCH] of: unittest: Don't dereference args.np after test errors

2018-09-24 Thread Frank Rowand
Hi Guenter, On 09/23/18 09:33, Guenter Roeck wrote: > If a devicetree parse function fails, it is quite likely that args.np > is invalid. Trying to dereference it will then cause the system to crash. > > This was seen when trying to run devicetree unittests on a g3beige > qemu system. This system

[PATCH] of: unittest: Don't dereference args.np after test errors

2018-09-23 Thread Guenter Roeck
If a devicetree parse function fails, it is quite likely that args.np is invalid. Trying to dereference it will then cause the system to crash. This was seen when trying to run devicetree unittests on a g3beige qemu system. This system has the OF_IMAP_OLDWORLD_MAC flag set in of_irq_workarounds an