Re: [PATCH] of: replace be32_to_cpu to be32_to_cpup

2019-04-30 Thread Phong Tran
On Tue, Apr 30, 2019 at 8:32 PM Christoph Hellwig wrote: > > On Tue, Apr 30, 2019 at 04:00:44PM +0700, Phong Tran wrote: > > > > diff --git a/include/linux/of.h b/include/linux/of.h > > index e240992e5cb6..1c35fc8f19b0 100644 > > --- a/include/linux/of.h > > +++ b/include/linux/of.h > > @@ -235,7

Re: [PATCH] of: replace be32_to_cpu to be32_to_cpup

2019-04-30 Thread Christoph Hellwig
On Tue, Apr 30, 2019 at 04:00:44PM +0700, Phong Tran wrote: > > diff --git a/include/linux/of.h b/include/linux/of.h > index e240992e5cb6..1c35fc8f19b0 100644 > --- a/include/linux/of.h > +++ b/include/linux/of.h > @@ -235,7 +235,7 @@ static inline u64 of_read_number(const __be32 *cell, int > siz

RE: [PATCH] of: replace be32_to_cpu to be32_to_cpup

2019-04-30 Thread David Laight
From: Phong Tran > Sent: 30 April 2019 10:01 > The cell is a pointer to __be32. > with the be32_to_cpu a lot of clang warning show that: > > ./include/linux/of.h:238:37: warning: multiple unsequenced modifications > to 'cell' [-Wunsequenced] > r = (r << 32) | be32_to_cpu(*(cell++))

Re: [PATCH] of: replace be32_to_cpu to be32_to_cpup

2019-04-30 Thread Nathan Chancellor
+ Nick and the list On Tue, Apr 30, 2019 at 04:00:44PM +0700, Phong Tran wrote: > The cell is a pointer to __be32. > with the be32_to_cpu a lot of clang warning show that: > > ./include/linux/of.h:238:37: warning: multiple unsequenced modifications > to 'cell' [-Wunsequenced] > r

[PATCH] of: replace be32_to_cpu to be32_to_cpup

2019-04-30 Thread Phong Tran
The cell is a pointer to __be32. with the be32_to_cpu a lot of clang warning show that: ./include/linux/of.h:238:37: warning: multiple unsequenced modifications to 'cell' [-Wunsequenced] r = (r << 32) | be32_to_cpu(*(cell++)); ^~ ./