Re: [PATCH] of: of_match_node: Make stub an inline function to avoid W=1 warnings

2020-08-30 Thread Andy Shevchenko
On Sun, Aug 30, 2020 at 6:25 PM Andrew Lunn wrote: > > On Fri, Aug 28, 2020 at 05:09:52PM -0600, Rob Herring wrote: > > On Fri, Aug 28, 2020 at 7:00 AM Andrew Lunn wrote: > > > > > > On Fri, Aug 28, 2020 at 04:19:39AM +0200, Andrew Lunn wrote: > > > > When building without CONFIG_OF and W=1, erro

Re: [PATCH] of: of_match_node: Make stub an inline function to avoid W=1 warnings

2020-08-30 Thread Andrew Lunn
On Fri, Aug 28, 2020 at 05:09:52PM -0600, Rob Herring wrote: > On Fri, Aug 28, 2020 at 7:00 AM Andrew Lunn wrote: > > > > On Fri, Aug 28, 2020 at 04:19:39AM +0200, Andrew Lunn wrote: > > > When building without CONFIG_OF and W=1, errors are given about unused > > > arrays of match data, because of

Re: [PATCH] of: of_match_node: Make stub an inline function to avoid W=1 warnings

2020-08-28 Thread Rob Herring
On Fri, Aug 28, 2020 at 7:00 AM Andrew Lunn wrote: > > On Fri, Aug 28, 2020 at 04:19:39AM +0200, Andrew Lunn wrote: > > When building without CONFIG_OF and W=1, errors are given about unused > > arrays of match data, because of_match_node is stubbed as a macro. The > > compile does not see it take

Re: [PATCH] of: of_match_node: Make stub an inline function to avoid W=1 warnings

2020-08-28 Thread Andrew Lunn
On Fri, Aug 28, 2020 at 04:19:39AM +0200, Andrew Lunn wrote: > When building without CONFIG_OF and W=1, errors are given about unused > arrays of match data, because of_match_node is stubbed as a macro. The > compile does not see it takes parameters when not astub, so it > generates warnings about

Re: [PATCH] of: of_match_node: Make stub an inline function to avoid W=1 warnings

2020-08-28 Thread kernel test robot
Hi Andrew, I love your patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on linux/master linus/master v5.9-rc2 next-20200828] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

Re: [PATCH] of: of_match_node: Make stub an inline function to avoid W=1 warnings

2020-08-28 Thread kernel test robot
Hi Andrew, I love your patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on linux/master linus/master v5.9-rc2 next-20200828] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

[PATCH] of: of_match_node: Make stub an inline function to avoid W=1 warnings

2020-08-27 Thread Andrew Lunn
When building without CONFIG_OF and W=1, errors are given about unused arrays of match data, because of_match_node is stubbed as a macro. The compile does not see it takes parameters when not astub, so it generates warnings about unused variables. Replace the stub with an inline function to avoid t