RE: [PATCH] of: fix of_update_property()

2014-02-04 Thread Grant Likely
On Mon, 20 Jan 2014 05:50:17 +, "li.xi...@freescale.com" wrote: > > Subject: Re: [PATCH] of: fix of_update_property() > > > > On Thu, Jan 16, 2014 at 10:46 PM, Xiubo Li wrote: > > > The of_update_property() is intent to update a property in a node >

RE: [PATCH] of: fix of_update_property()

2014-01-19 Thread li.xi...@freescale.com
> Subject: Re: [PATCH] of: fix of_update_property() > > On Thu, Jan 16, 2014 at 10:46 PM, Xiubo Li wrote: > > The of_update_property() is intent to update a property in a node > > s/intent/indended/ > > > and if the property does not exist, will add it to the node

Re: [PATCH] of: fix of_update_property()

2014-01-17 Thread Pantelis Antoniou
Hi Rob, On Jan 17, 2014, at 4:49 PM, Rob Herring wrote: > On Thu, Jan 16, 2014 at 10:46 PM, Xiubo Li wrote: >> The of_update_property() is intent to update a property in a node > [ snip ] >>return of_add_property(np, newprop); > > Isn't there also a race that if you do 2 upda

Re: [PATCH] of: fix of_update_property()

2014-01-17 Thread Rob Herring
On Thu, Jan 16, 2014 at 10:46 PM, Xiubo Li wrote: > The of_update_property() is intent to update a property in a node s/intent/indended/ > and if the property does not exist, will add it to the node. > > The second search of the property is possibly won't be found, that > maybe removed by other

[PATCH] of: fix of_update_property()

2014-01-16 Thread Xiubo Li
The of_update_property() is intent to update a property in a node and if the property does not exist, will add it to the node. The second search of the property is possibly won't be found, that maybe removed by other thread just before the second search begain, if so just retry it. Signed-off-by: