Re: [PATCH] of: Fix memory block alignment in early_init_dt_add_memory_arch()

2014-09-08 Thread Grant Likely
On Wed, 27 Aug 2014 13:08:51 +0200, Geert Uytterhoeven wrote: > Hi Grant, > > On Wed, Aug 27, 2014 at 12:30 PM, Grant Likely > wrote: > > On Wed, 20 Aug 2014 17:10:31 +0200, Geert Uytterhoeven > > wrote: > >> If a memory block is not aligned to PAGE_SIZE, its base address must be > >> rounde

Re: [PATCH] of: Fix memory block alignment in early_init_dt_add_memory_arch()

2014-08-27 Thread Geert Uytterhoeven
Hi Grant, On Wed, Aug 27, 2014 at 12:30 PM, Grant Likely wrote: > On Wed, 20 Aug 2014 17:10:31 +0200, Geert Uytterhoeven > wrote: >> If a memory block is not aligned to PAGE_SIZE, its base address must be >> rounded up, not down, and its size must be reduced. >> >> Signed-off-by: Geert Uytterho

Re: [PATCH] of: Fix memory block alignment in early_init_dt_add_memory_arch()

2014-08-27 Thread Grant Likely
On Wed, 20 Aug 2014 17:10:31 +0200, Geert Uytterhoeven wrote: > If a memory block is not aligned to PAGE_SIZE, its base address must be > rounded up, not down, and its size must be reduced. > > Signed-off-by: Geert Uytterhoeven Looks reasonable. What is the situation that exposed this problem?

[PATCH] of: Fix memory block alignment in early_init_dt_add_memory_arch()

2014-08-20 Thread Geert Uytterhoeven
If a memory block is not aligned to PAGE_SIZE, its base address must be rounded up, not down, and its size must be reduced. Signed-off-by: Geert Uytterhoeven --- drivers/of/fdt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index f4