Re: [PATCH] ocfs2: fix unbalanced locking

2020-07-27 Thread Joseph Qi
On 2020/7/24 20:44, Pavel Machek wrote: > > Based on what fails, function can return with nfs_sync_rwlock either > locked or unlocked. That can not be right. > > Always return with lock unlocked on error. > > Signed-off-by: Pavel Machek (CIP) Looks good. Fixes: 4cd9973f9ff6 ("ocfs2: avoid

[PATCH] ocfs2: fix unbalanced locking

2020-07-24 Thread Pavel Machek
Based on what fails, function can return with nfs_sync_rwlock either locked or unlocked. That can not be right. Always return with lock unlocked on error. Signed-off-by: Pavel Machek (CIP) diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index 751bc4dc7466..8e3a369086db 100644 --- a/fs/ocf