Re: [PATCH] objtool: Fix memory leak in decode_instructions()

2017-10-22 Thread Kamalesh Babulal
On Thursday 19 October 2017 08:02 PM, Josh Poimboeuf wrote: On Thu, Oct 19, 2017 at 09:31:37AM -0500, Josh Poimboeuf wrote: On Fri, Oct 13, 2017 at 11:20:58AM +0530, Kamalesh Babulal wrote: On Friday 13 October 2017 10:36 AM, Josh Poimboeuf wrote: On Fri, Oct 13, 2017 at 10:14:36AM +0530, Kama

Re: [PATCH] objtool: Fix memory leak in decode_instructions()

2017-10-20 Thread Ingo Molnar
* Josh Poimboeuf wrote: > On Thu, Oct 19, 2017 at 05:21:06PM +0200, Ingo Molnar wrote: > > > > * Josh Poimboeuf wrote: > > > > > Hi Ingo, > > > > > > I'm not sure if you saw the below ACK. In general, for objtool patches > > > which don't have you on CC, is it ok if I just add you to CC alo

[PATCH] objtool: Fix memory leak in decode_instructions()

2017-10-19 Thread Josh Poimboeuf
From: Kamalesh Babulal When an error occurs before adding an allocated insn to the list, free it before returning. Signed-off-by: Kamalesh Babulal Signed-off-by: Josh Poimboeuf --- tools/objtool/check.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/objtool

Re: [PATCH] objtool: Fix memory leak in decode_instructions()

2017-10-19 Thread Josh Poimboeuf
On Thu, Oct 19, 2017 at 05:21:06PM +0200, Ingo Molnar wrote: > > * Josh Poimboeuf wrote: > > > Hi Ingo, > > > > I'm not sure if you saw the below ACK. In general, for objtool patches > > which don't have you on CC, is it ok if I just add you to CC along with > > the ACK? Or would you prefer I

Re: [PATCH] objtool: Fix memory leak in decode_instructions()

2017-10-19 Thread Ingo Molnar
* Josh Poimboeuf wrote: > Hi Ingo, > > I'm not sure if you saw the below ACK. In general, for objtool patches > which don't have you on CC, is it ok if I just add you to CC along with > the ACK? Or would you prefer I resend the patch to you with my SOB? Yeah, that would be nice - that way I

Re: [PATCH] objtool: Fix memory leak in decode_instructions()

2017-10-19 Thread Josh Poimboeuf
On Thu, Oct 19, 2017 at 09:31:37AM -0500, Josh Poimboeuf wrote: > On Fri, Oct 13, 2017 at 11:20:58AM +0530, Kamalesh Babulal wrote: > > On Friday 13 October 2017 10:36 AM, Josh Poimboeuf wrote: > > > On Fri, Oct 13, 2017 at 10:14:36AM +0530, Kamalesh Babulal wrote: > > > > On Thursday 12 October 20

Re: [PATCH] objtool: Fix memory leak in decode_instructions()

2017-10-19 Thread Josh Poimboeuf
On Fri, Oct 13, 2017 at 11:20:58AM +0530, Kamalesh Babulal wrote: > On Friday 13 October 2017 10:36 AM, Josh Poimboeuf wrote: > > On Fri, Oct 13, 2017 at 10:14:36AM +0530, Kamalesh Babulal wrote: > > > On Thursday 12 October 2017 09:40 PM, Josh Poimboeuf wrote: > > > > On Thu, Oct 12, 2017 at 02:32

Re: [PATCH] objtool: Fix memory leak in decode_instructions()

2017-10-19 Thread Josh Poimboeuf
Hi Ingo, I'm not sure if you saw the below ACK. In general, for objtool patches which don't have you on CC, is it ok if I just add you to CC along with the ACK? Or would you prefer I resend the patch to you with my SOB? Or, would you rather I start queueing patches and doing pull requests weekl

Re: [PATCH] objtool: Fix memory leak in decode_instructions()

2017-10-12 Thread Kamalesh Babulal
On Friday 13 October 2017 10:36 AM, Josh Poimboeuf wrote: On Fri, Oct 13, 2017 at 10:14:36AM +0530, Kamalesh Babulal wrote: On Thursday 12 October 2017 09:40 PM, Josh Poimboeuf wrote: On Thu, Oct 12, 2017 at 02:32:14PM +0530, Kamalesh Babulal wrote: free the allocated insn before returning, wh

Re: [PATCH] objtool: Fix memory leak in decode_instructions()

2017-10-12 Thread Josh Poimboeuf
On Fri, Oct 13, 2017 at 10:14:36AM +0530, Kamalesh Babulal wrote: > On Thursday 12 October 2017 09:40 PM, Josh Poimboeuf wrote: > > On Thu, Oct 12, 2017 at 02:32:14PM +0530, Kamalesh Babulal wrote: > > > free the allocated insn before returning, when an error occurs > > > before adding insn to file

Re: [PATCH] objtool: Fix memory leak in decode_instructions()

2017-10-12 Thread Kamalesh Babulal
On Thursday 12 October 2017 09:40 PM, Josh Poimboeuf wrote: On Thu, Oct 12, 2017 at 02:32:14PM +0530, Kamalesh Babulal wrote: free the allocated insn before returning, when an error occurs before adding insn to file->insn_list. Signed-off-by: Kamalesh Babulal Any chance you're working on por

Re: [PATCH] objtool: Fix memory leak in decode_instructions()

2017-10-12 Thread Josh Poimboeuf
On Thu, Oct 12, 2017 at 02:32:14PM +0530, Kamalesh Babulal wrote: > free the allocated insn before returning, when an error occurs > before adding insn to file->insn_list. > > Signed-off-by: Kamalesh Babulal Any chance you're working on porting objtool to ppc64le? :-) Acked-by: Josh Poimboeuf

[PATCH] objtool: Fix memory leak in decode_instructions()

2017-10-12 Thread Kamalesh Babulal
free the allocated insn before returning, when an error occurs before adding insn to file->insn_list. Signed-off-by: Kamalesh Babulal --- tools/objtool/check.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index a0c518e