Re: [PATCH] objtool: Fix clang enum conversion warning

2017-12-28 Thread Ingo Molnar
* Josh Poimboeuf wrote: > On Wed, Dec 27, 2017 at 10:42:45PM -0500, Nick Desaulniers wrote: > > On Wed, Dec 27, 2017 at 12:38 PM, Josh Poimboeuf > > wrote: > > > On Wed, Dec 27, 2017 at 01:34:34PM +0100, Lukas Bulwahn wrote: > > >> Assuming that the authorship of this one-line change does not

Re: [PATCH] objtool: Fix clang enum conversion warning

2017-12-28 Thread Lukas Bulwahn
On Wed, 27 Dec 2017, Josh Poimboeuf wrote: The patch from Lukas was the first one I received, so that's the one I used. I rewrote the commit msg for clarity and added my SOB and sent it to Ingo for merging. Josh, Ingo, the first patch I sent to Josh must have been a v0, which I probably d

Re: [PATCH] objtool: Fix clang enum conversion warning

2017-12-27 Thread Josh Poimboeuf
On Wed, Dec 27, 2017 at 10:42:45PM -0500, Nick Desaulniers wrote: > On Wed, Dec 27, 2017 at 12:38 PM, Josh Poimboeuf wrote: > > On Wed, Dec 27, 2017 at 01:34:34PM +0100, Lukas Bulwahn wrote: > >> Assuming that the authorship of this one-line change does not matter, as it > >> is largely suggested

Re: [PATCH] objtool: Fix clang enum conversion warning

2017-12-27 Thread Nick Desaulniers
On Wed, Dec 27, 2017 at 12:38 PM, Josh Poimboeuf wrote: > On Wed, Dec 27, 2017 at 01:34:34PM +0100, Lukas Bulwahn wrote: >> Assuming that the authorship of this one-line change does not matter, as it >> is largely suggested by the clang compiler anyway, and we want to move the >> change forward, w

Re: [PATCH] objtool: Fix clang enum conversion warning

2017-12-27 Thread Josh Poimboeuf
On Wed, Dec 27, 2017 at 01:34:34PM +0100, Lukas Bulwahn wrote: > > On Tue, 26 Dec 2017, Nick Desaulniers wrote: > > > I sent a similar one recently: > > https://patchwork.kernel.org/patch/10131815/ (maybe Josh is just > > forwarding me an earlier fix?) > > > > Reviewed-by: Nick Desaulniers > >

Re: [PATCH] objtool: Fix clang enum conversion warning

2017-12-27 Thread Lukas Bulwahn
On Tue, 26 Dec 2017, Nick Desaulniers wrote: I sent a similar one recently: https://patchwork.kernel.org/patch/10131815/ (maybe Josh is just forwarding me an earlier fix?) Reviewed-by: Nick Desaulniers I actually submitted this (other) patch to LKML on 2017-12-10: https://patchwork.kernel

Re: [PATCH] objtool: Fix clang enum conversion warning

2017-12-26 Thread Nick Desaulniers
I sent a similar one recently: https://patchwork.kernel.org/patch/10131815/ (maybe Josh is just forwarding me an earlier fix?) Reviewed-by: Nick Desaulniers On Tue, Dec 26, 2017 at 4:27 PM, Josh Poimboeuf wrote: > From: Lukas Bulwahn > > Fix the following clang enum conversion warning: > > a

[PATCH] objtool: Fix clang enum conversion warning

2017-12-26 Thread Josh Poimboeuf
From: Lukas Bulwahn Fix the following clang enum conversion warning: arch/x86/decode.c:141:20: error: implicit conversion from enumeration type 'enum op_src_type' to different enumeration type 'enum op_dest_type' [-Werror,-Wenum-conversion] op->dest.type = OP_SRC_REG;