Re: [PATCH] nvmem: qfprom: Fix to support single byte read/write

2016-11-16 Thread Stephen Boyd
On 11/16, Vivek Gautam wrote: > Hi Stephen, > > On Wed, Nov 16, 2016 at 12:29 AM, Stephen Boyd wrote: > > On 11/15, Vivek Gautam wrote: > >> @@ -53,7 +53,7 @@ static int qfprom_remove(struct platform_device *pdev) > >> static struct nvmem_config econfig = { > >> .name = "qfprom", > >>

Re: [PATCH] nvmem: qfprom: Fix to support single byte read/write

2016-11-15 Thread Vivek Gautam
Hi Stephen, On Wed, Nov 16, 2016 at 12:29 AM, Stephen Boyd wrote: > On 11/15, Vivek Gautam wrote: >> @@ -53,7 +53,7 @@ static int qfprom_remove(struct platform_device *pdev) >> static struct nvmem_config econfig = { >> .name = "qfprom", >> .owner = THIS_MODULE, >> - .stride = 4,

Re: [PATCH] nvmem: qfprom: Fix to support single byte read/write

2016-11-15 Thread Stephen Boyd
On 11/15, Vivek Gautam wrote: > @@ -53,7 +53,7 @@ static int qfprom_remove(struct platform_device *pdev) > static struct nvmem_config econfig = { > .name = "qfprom", > .owner = THIS_MODULE, > - .stride = 4, > + .stride = 1, Are we certain that all qfproms support byte accesses

[PATCH] nvmem: qfprom: Fix to support single byte read/write

2016-11-15 Thread Vivek Gautam
The nvmem core driver supports to read and write single byte. This helps in extracting a required value based on bit-offset and number of bits for the required value in the nvmem cell. Signed-off-by: Vivek Gautam --- Based on torvalds's master branch. - Tested on db410c for thermal sensors, an