Re: [PATCH] nvme-pci: ensure nvme_timeout complete before initializing procedure

2018-01-22 Thread jianchao.wang
Hi Christoph and Keith Really sorry for this. On 01/23/2018 05:54 AM, Keith Busch wrote: > On Mon, Jan 22, 2018 at 09:14:23PM +0100, Christoph Hellwig wrote: >>> Link: >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lkml.org_lkml_2018_1_19_68&d=DwICAg&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB

Re: [PATCH] nvme-pci: ensure nvme_timeout complete before initializing procedure

2018-01-22 Thread Keith Busch
On Mon, Jan 22, 2018 at 09:14:23PM +0100, Christoph Hellwig wrote: > > Link: https://lkml.org/lkml/2018/1/19/68 > > Suggested-by: Keith Busch > > Signed-off-by: Keith Busch > > Signed-off-by: Jianchao Wang > > Why does this have a signoff from Keith? Right, I hadn't signed off that. I just try

Re: [PATCH] nvme-pci: ensure nvme_timeout complete before initializing procedure

2018-01-22 Thread Christoph Hellwig
> Link: https://lkml.org/lkml/2018/1/19/68 > Suggested-by: Keith Busch > Signed-off-by: Keith Busch > Signed-off-by: Jianchao Wang Why does this have a signoff from Keith?

[PATCH] nvme-pci: ensure nvme_timeout complete before initializing procedure

2018-01-21 Thread Jianchao Wang
There could be a nvme_timeout running with nvme_dev_disable in parallel. The requests held by timeout path cannot be canceled by nvme_dev_disable. Consequently, the nvme_timeout maybe still running after nvme_dev_disable completes. Then there could be a race between nvme_dev_disable in nvme_timeout