Re: [PATCH] nvme: add back dependency on CONFIG_BLOCK

2016-09-06 Thread Christoph Hellwig
On Tue, Sep 06, 2016 at 04:09:26PM +0300, Sagi Grimberg wrote: > Thanks Arnd, queued for the next round of rc fixes. > > With a slight modification to the component in the subject line > (nvme-rdma). Shouldn't we just have a if BLOCK around all the entries in the Kconfig?

Re: [PATCH] nvme: add back dependency on CONFIG_BLOCK

2016-09-06 Thread Sagi Grimberg
A recent change removed the dependency on BLK_DEV_NVME, which implies the dependency on PCI and BLOCK. We don't need CONFIG_PCI, but without CONFIG_BLOCK we get tons of build errors, e.g. Thanks Arnd, queued for the next round of rc fixes. With a slight modification to the component in the su

[PATCH] nvme: add back dependency on CONFIG_BLOCK

2016-09-06 Thread Arnd Bergmann
A recent change removed the dependency on BLK_DEV_NVME, which implies the dependency on PCI and BLOCK. We don't need CONFIG_PCI, but without CONFIG_BLOCK we get tons of build errors, e.g. In file included from drivers/nvme/host/core.c:16:0: linux/blk-mq.h:182:33: error: 'struct gendisk' declared i