Re: [PATCH] nvme: Remove redundant validation in nvme_start_ctrl()

2020-07-14 Thread Christoph Hellwig
On Mon, Jul 13, 2020 at 02:25:21PM +0800, Baolin Wang wrote: > We've already validated the 'kato' in nvme_start_keep_alive(), thus no > need to validate it again in nvme_start_ctrl(). Remove it. Thanks, applied to nvme-5.9.

Re: [PATCH] nvme: Remove redundant validation in nvme_start_ctrl()

2020-07-13 Thread Chaitanya Kulkarni
On 7/13/20 20:24, Baolin Wang wrote: >> Since start keep alive is so small to make a function call how about we >> in-line the call ? untested patch :- > I am Okay about your suggestion. Will send v2 with your suggested-by tag > if no other objection. Thanks. > Keith, Christoph are you guys okay

Re: [PATCH] nvme: Remove redundant validation in nvme_start_ctrl()

2020-07-13 Thread Baolin Wang
On Mon, Jul 13, 2020 at 11:58:18PM +, Chaitanya Kulkarni wrote: > On 7/12/20 23:31, Baolin Wang wrote: > > We've already validated the 'kato' in nvme_start_keep_alive(), thus no > > need to validate it again in nvme_start_ctrl(). Remove it. > > > > Signed-off-by: Baolin Wang > > --- > > dri

Re: [PATCH] nvme: Remove redundant validation in nvme_start_ctrl()

2020-07-13 Thread Chaitanya Kulkarni
On 7/12/20 23:31, Baolin Wang wrote: > We've already validated the 'kato' in nvme_start_keep_alive(), thus no > need to validate it again in nvme_start_ctrl(). Remove it. > > Signed-off-by: Baolin Wang > --- > drivers/nvme/host/core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >

[PATCH] nvme: Remove redundant validation in nvme_start_ctrl()

2020-07-12 Thread Baolin Wang
We've already validated the 'kato' in nvme_start_keep_alive(), thus no need to validate it again in nvme_start_ctrl(). Remove it. Signed-off-by: Baolin Wang --- drivers/nvme/host/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/