Re: [PATCH] nvme: Cleanup nvme_dev_start() and fix IRQ leak

2014-01-21 Thread Alexander Gordeev
On Mon, Jan 20, 2014 at 03:48:56PM -0700, Keith Busch wrote: > On Mon, 20 Jan 2014, Alexander Gordeev wrote: > >This is an attempt to make handling of admin queue in a > >single scope. This update also fixes a IRQ leak in case > >nvme_setup_io_queues() failed to allocate enough iomem > >and bailed

Re: [PATCH] nvme: Cleanup nvme_dev_start() and fix IRQ leak

2014-01-20 Thread Keith Busch
On Mon, 20 Jan 2014, Alexander Gordeev wrote: This is an attempt to make handling of admin queue in a single scope. This update also fixes a IRQ leak in case nvme_setup_io_queues() failed to allocate enough iomem and bailed out with -ENOMEM errno. This definitely seems to improve the code flow,

[PATCH] nvme: Cleanup nvme_dev_start() and fix IRQ leak

2014-01-20 Thread Alexander Gordeev
This is an attempt to make handling of admin queue in a single scope. This update also fixes a IRQ leak in case nvme_setup_io_queues() failed to allocate enough iomem and bailed out with -ENOMEM errno. Signed-off-by: Alexander Gordeev --- drivers/block/nvme-core.c | 44 +++-