Re: [PATCH] null_blk: Register as a LightNVM device

2015-11-12 Thread Matias Bjørling
On 11/12/2015 05:00 PM, Jens Axboe wrote: On 11/12/2015 08:58 AM, Christoph Hellwig wrote: On Thu, Nov 12, 2015 at 08:54:48AM -0700, Jens Axboe wrote: 300 lines of boilerplate for just setting up a few request_queues seem wrong, can you show the actual patch you measured? I just took it from

Re: [PATCH] null_blk: Register as a LightNVM device

2015-11-12 Thread Jens Axboe
On 11/12/2015 08:52 AM, Christoph Hellwig wrote: On Thu, Nov 12, 2015 at 08:49:08AM -0700, Jens Axboe wrote: But it still avoids duplicating the generics of it. Patch for null_blk: 3 files changed, 168 insertions(+), 7 deletions (-) vs a standalone of: 3 files changed, 459 insertions(+) It d

Re: [PATCH] null_blk: Register as a LightNVM device

2015-11-12 Thread Jens Axboe
On 11/12/2015 08:58 AM, Christoph Hellwig wrote: On Thu, Nov 12, 2015 at 08:54:48AM -0700, Jens Axboe wrote: 300 lines of boilerplate for just setting up a few request_queues seem wrong, can you show the actual patch you measured? I just took it from Matias' last posting: http://marc.info/?l=

Re: [PATCH] null_blk: Register as a LightNVM device

2015-11-12 Thread Christoph Hellwig
On Thu, Nov 12, 2015 at 08:54:48AM -0700, Jens Axboe wrote: > >300 lines of boilerplate for just setting up a few request_queues seem > >wrong, can you show the actual patch you measured? > > I just took it from Matias' last posting: > > http://marc.info/?l=linux-kernel&m=144605858228534&w=2 Wel

Re: [PATCH] null_blk: Register as a LightNVM device

2015-11-12 Thread Jens Axboe
On 11/12/2015 01:53 AM, Christoph Hellwig wrote: On Wed, Nov 11, 2015 at 11:06:38AM +0100, Matias Bj??rling wrote: Add support for registering as a LightNVM device. This allows us to evaluate the performance of the LightNVM library. In /drivers/Makefile, LightNVM is moved above block device dri

Re: [PATCH] null_blk: Register as a LightNVM device

2015-11-12 Thread Christoph Hellwig
On Thu, Nov 12, 2015 at 08:49:08AM -0700, Jens Axboe wrote: > But it still avoids duplicating the generics of it. Patch for null_blk: > > 3 files changed, 168 insertions(+), 7 deletions (-) > > vs a standalone of: > > 3 files changed, 459 insertions(+) > > It doesn't screw up null_blk, so I'd p

Re: [PATCH] null_blk: Register as a LightNVM device

2015-11-12 Thread Matias Bjørling
On 11/11/2015 11:11 PM, Jens Axboe wrote: On 11/11/2015 02:27 PM, Jens Axboe wrote: On 11/11/2015 03:06 AM, Matias Bjørling wrote: Add support for registering as a LightNVM device. This allows us to evaluate the performance of the LightNVM library. In /drivers/Makefile, LightNVM is moved above

Re: [PATCH] null_blk: Register as a LightNVM device

2015-11-12 Thread Christoph Hellwig
On Wed, Nov 11, 2015 at 11:06:38AM +0100, Matias Bj??rling wrote: > Add support for registering as a LightNVM device. This allows us to > evaluate the performance of the LightNVM library. > > In /drivers/Makefile, LightNVM is moved above block device drivers > to make sure that the LightNVM media

Re: [PATCH] null_blk: Register as a LightNVM device

2015-11-11 Thread Jens Axboe
On 11/11/2015 02:27 PM, Jens Axboe wrote: On 11/11/2015 03:06 AM, Matias Bjørling wrote: Add support for registering as a LightNVM device. This allows us to evaluate the performance of the LightNVM library. In /drivers/Makefile, LightNVM is moved above block device drivers to make sure that the

Re: [PATCH] null_blk: Register as a LightNVM device

2015-11-11 Thread Jens Axboe
On 11/11/2015 03:06 AM, Matias Bjørling wrote: Add support for registering as a LightNVM device. This allows us to evaluate the performance of the LightNVM library. In /drivers/Makefile, LightNVM is moved above block device drivers to make sure that the LightNVM media managers have been initiali

[PATCH] null_blk: Register as a LightNVM device

2015-11-11 Thread Matias Bjørling
Add support for registering as a LightNVM device. This allows us to evaluate the performance of the LightNVM library. In /drivers/Makefile, LightNVM is moved above block device drivers to make sure that the LightNVM media managers have been initialized before drivers under /drivers/block are initi