On Tue, 8 May 2018, Geert Uytterhoeven wrote:
> nubus_bus_register() two things:
>
> 1. Register the NuBus parent device, which represents the bus host,
> 2. Register the NuBus bus, which represents the bus type.
>
> I think this should be split in two, and only the latter should be done
>
Hi Greg,
Am 08.05.2018 um 19:25 schrieb Greg Kroah-Hartman:
> On Tue, May 08, 2018 at 09:07:27AM +0200, Geert Uytterhoeven wrote:
>> Hi Greg,
>>
>> On Tue, May 8, 2018 at 9:00 AM, Greg Kroah-Hartman
>> wrote:
>>> On Mon, May 07, 2018 at 09:51:12AM +1200, Michael Schmitz wrote:
the BUG() was
On Tue, 8 May 2018, Geert Uytterhoeven wrote:
> > This example is the sort of flag removal that I had in mind --
> >
> > diff --git a/drivers/base/driver.c b/drivers/base/driver.c
> > index ba912558a510..4ee22fb3db92 100644
> > --- a/drivers/base/driver.c
> > +++ b/drivers/base/driver.c
> > @@ -14
On Tue, May 08, 2018 at 09:35:10AM +0200, Geert Uytterhoeven wrote:
> Hi Greg,
>
> On Tue, May 8, 2018 at 9:25 AM, Greg Kroah-Hartman
> wrote:
> > On Tue, May 08, 2018 at 09:07:27AM +0200, Geert Uytterhoeven wrote:
> >> On Tue, May 8, 2018 at 9:00 AM, Greg Kroah-Hartman
> >> wrote:
> >> > On Mon
Hi Finn,
On Sun, May 6, 2018 at 3:47 AM, Finn Thain wrote:
> Loading a NuBus driver module on a non-NuBus machine triggers the
> BUG_ON(!drv->bus->p) in driver_register() because the bus does not get
> registered unless MACH_IS_MAC(). Avoid this by registering the bus
> unconditionally using post
Hi Greg,
On Tue, May 8, 2018 at 9:25 AM, Greg Kroah-Hartman
wrote:
> On Tue, May 08, 2018 at 09:07:27AM +0200, Geert Uytterhoeven wrote:
>> On Tue, May 8, 2018 at 9:00 AM, Greg Kroah-Hartman
>> wrote:
>> > On Mon, May 07, 2018 at 09:51:12AM +1200, Michael Schmitz wrote:
>> >> the BUG() was trigg
On Tue, May 08, 2018 at 09:07:27AM +0200, Geert Uytterhoeven wrote:
> Hi Greg,
>
> On Tue, May 8, 2018 at 9:00 AM, Greg Kroah-Hartman
> wrote:
> > On Mon, May 07, 2018 at 09:51:12AM +1200, Michael Schmitz wrote:
> >> the BUG() was triggered by loading a Mac Nubus network card module on
> >> a mul
Hi Greg,
On Tue, May 8, 2018 at 9:00 AM, Greg Kroah-Hartman
wrote:
> On Mon, May 07, 2018 at 09:51:12AM +1200, Michael Schmitz wrote:
>> the BUG() was triggered by loading a Mac Nubus network card module on
>> a multiplatform kernel running on an Amiga machine. Up to Finn's Nubus
>> core rewrite
On Mon, May 07, 2018 at 09:57:22AM +1000, Finn Thain wrote:
> On Sun, 6 May 2018, Greg Kroah-Hartman wrote:
>
> > > > Why not just have an "bus is registered" flag in your driver
> > > > register function that refuses to let drivers register with the
> > > > driver core if it isn't set?
> > >
>
On Mon, May 07, 2018 at 09:51:12AM +1200, Michael Schmitz wrote:
> Hi Greg,
>
> the BUG() was triggered by loading a Mac Nubus network card module on
> a multiplatform kernel running on an Amiga machine. Up to Finn's Nubus
> core rewrite (this February), we've seen no errors. Since then, Nubus
> d
Hi Finn,
On Tue, May 8, 2018 at 1:44 AM, Finn Thain wrote:
> On Mon, 7 May 2018, I wrote:
>> On Sun, 6 May 2018, Greg Kroah-Hartman wrote:
>> > > > Why not just have an "bus is registered" flag in your driver
>> > > > register function that refuses to let drivers register with the
>> > > > driver
Hi Greg,
On Mon, May 7, 2018 at 4:45 PM, Greg Kroah-Hartman
wrote:
> On Mon, May 07, 2018 at 02:53:13PM +0200, Geert Uytterhoeven wrote:
>> On Mon, May 7, 2018 at 1:57 AM, Finn Thain
>> wrote:
>> > On Sun, 6 May 2018, Greg Kroah-Hartman wrote:
>> >> > > Why not just have an "bus is registered"
On Mon, 7 May 2018, I wrote:
> On Sun, 6 May 2018, Greg Kroah-Hartman wrote:
>
> > > > Why not just have an "bus is registered" flag in your driver
> > > > register function that refuses to let drivers register with the
> > > > driver core if it isn't set?
> > >
> > > Perhaps that should happe
On Mon, May 07, 2018 at 02:53:13PM +0200, Geert Uytterhoeven wrote:
> Hi Finn,
>
> (responding immediately to patches doing non-kosher things ;-)
>
> On Mon, May 7, 2018 at 1:57 AM, Finn Thain wrote:
> > On Sun, 6 May 2018, Greg Kroah-Hartman wrote:
> >> > > Why not just have an "bus is register
Hi Finn,
(responding immediately to patches doing non-kosher things ;-)
On Mon, May 7, 2018 at 1:57 AM, Finn Thain wrote:
> On Sun, 6 May 2018, Greg Kroah-Hartman wrote:
>> > > Why not just have an "bus is registered" flag in your driver
>> > > register function that refuses to let drivers regis
On Sun, 6 May 2018, Greg Kroah-Hartman wrote:
> > > Why not just have an "bus is registered" flag in your driver
> > > register function that refuses to let drivers register with the
> > > driver core if it isn't set?
> >
> > Perhaps that should happen in the core driver_register() function.
>
Hi Greg,
the BUG() was triggered by loading a Mac Nubus network card module on
a multiplatform kernel running on an Amiga machine. Up to Finn's Nubus
core rewrite (this February), we've seen no errors. Since then, Nubus
drivers fail to register because the Nubus bus is only registered on
Macs.
Ca
On Sun, May 06, 2018 at 04:00:15PM +1000, Finn Thain wrote:
> On Sat, 5 May 2018, Greg Kroah-Hartman wrote:
>
> > On Sun, May 06, 2018 at 11:47:52AM +1000, Finn Thain wrote:
> > > Loading a NuBus driver module on a non-NuBus machine triggers the
> > > BUG_ON(!drv->bus->p) in driver_register() beca
On Sat, 5 May 2018, Greg Kroah-Hartman wrote:
> On Sun, May 06, 2018 at 11:47:52AM +1000, Finn Thain wrote:
> > Loading a NuBus driver module on a non-NuBus machine triggers the
> > BUG_ON(!drv->bus->p) in driver_register() because the bus does not get
> > registered unless MACH_IS_MAC(). Avoid th
On Sun, May 06, 2018 at 11:47:52AM +1000, Finn Thain wrote:
> Loading a NuBus driver module on a non-NuBus machine triggers the
> BUG_ON(!drv->bus->p) in driver_register() because the bus does not get
> registered unless MACH_IS_MAC(). Avoid this by registering the bus
> unconditionally using postc
Loading a NuBus driver module on a non-NuBus machine triggers the
BUG_ON(!drv->bus->p) in driver_register() because the bus does not get
registered unless MACH_IS_MAC(). Avoid this by registering the bus
unconditionally using postcore_initcall().
Cc: Greg Kroah-Hartman
Reported-by: Michael Schmit
21 matches
Mail list logo
