Re: [PATCH] ntb_hw_switchtec: fix logic error

2017-12-06 Thread Logan Gunthorpe
Hey, Thanks, nice catch. On 06/12/17 07:19 AM, Arnd Bergmann wrote: Newer gcc (version 7 and 8 presumably) warn about a statement mixing the << operator with logical and: drivers/ntb/hw/mscc/ntb_hw_switchtec.c: In function 'switchtec_ntb_init_sndev': drivers/ntb/hw/mscc/ntb_hw_switchtec.c:888:

[PATCH] ntb_hw_switchtec: fix logic error

2017-12-06 Thread Arnd Bergmann
Newer gcc (version 7 and 8 presumably) warn about a statement mixing the << operator with logical and: drivers/ntb/hw/mscc/ntb_hw_switchtec.c: In function 'switchtec_ntb_init_sndev': drivers/ntb/hw/mscc/ntb_hw_switchtec.c:888:24: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-