Re: [PATCH] nokia n900: update dts with camera support

2017-08-28 Thread Ivaylo Dimitrov
Hi On 28.08.2017 18:07, Sakari Ailus wrote: Hi Pavel, On Mon, Aug 28, 2017 at 03:59:59PM +0200, Pavel Machek wrote: Hi! Well, strobe property above already uses = <0>/<1> format, as do others. Problem with "false = property does not exist" is that you don't know if it is "someone forgot t

Re: [PATCH] nokia n900: update dts with camera support

2017-08-28 Thread Sakari Ailus
Hi Pavel, On Mon, Aug 28, 2017 at 03:59:59PM +0200, Pavel Machek wrote: > Hi! > > > > > Well, strobe property above already uses = <0>/<1> format, as do > > > > others. > > > > > > > Problem with "false = property does not exist" is that you don't know > > > > if it is "someone forgot to define i

Re: [PATCH] nokia n900: update dts with camera support

2017-08-28 Thread Pavel Machek
Hi! > > > Well, strobe property above already uses = <0>/<1> format, as do > > > others. > > > > > Problem with "false = property does not exist" is that you don't know > > > if it is "someone forgot to define it" or "someone made a typo" or > > > "dts is too old to know about this property" or "t

Re: [PATCH] nokia n900: update dts with camera support

2017-08-16 Thread Sakari Ailus
Sebastian Reichel wrote: > Hi, > > On Thu, Aug 17, 2017 at 12:23:44AM +0300, Sakari Ailus wrote: >> On Wed, Aug 16, 2017 at 10:59:15PM +0200, Pavel Machek wrote: On Wed, Aug 16, 2017 at 12:03:49AM +0200, Pavel Machek wrote: > diff --git a/Documentation/devicetree/bindings/media/video-inte

Re: [PATCH] nokia n900: update dts with camera support

2017-08-16 Thread Sebastian Reichel
Hi, On Thu, Aug 17, 2017 at 12:23:44AM +0300, Sakari Ailus wrote: > On Wed, Aug 16, 2017 at 10:59:15PM +0200, Pavel Machek wrote: > > > On Wed, Aug 16, 2017 at 12:03:49AM +0200, Pavel Machek wrote: > > > > diff --git > > > > a/Documentation/devicetree/bindings/media/video-interfaces.txt > > > >

Re: [PATCH] nokia n900: update dts with camera support

2017-08-16 Thread Sakari Ailus
On Wed, Aug 16, 2017 at 10:59:15PM +0200, Pavel Machek wrote: > > Hi, > > > > On Wed, Aug 16, 2017 at 12:03:49AM +0200, Pavel Machek wrote: > > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt > > > b/Documentation/devicetree/bindings/media/video-interfaces.txt > > > in

Re: [PATCH] nokia n900: update dts with camera support

2017-08-16 Thread Pavel Machek
> Hi, > > On Wed, Aug 16, 2017 at 12:03:49AM +0200, Pavel Machek wrote: > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt > > b/Documentation/devicetree/bindings/media/video-interfaces.txt > > index 852041a..aade681 100644 > > --- a/Documentation/devicetree/bindings/me

Re: [PATCH] nokia n900: update dts with camera support

2017-08-16 Thread Sebastian Reichel
Hi, On Wed, Aug 16, 2017 at 12:03:49AM +0200, Pavel Machek wrote: > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt > b/Documentation/devicetree/bindings/media/video-interfaces.txt > index 852041a..aade681 100644 > --- a/Documentation/devicetree/bindings/media/video-inte

Re: [PATCH] nokia n900: update dts with camera support

2017-08-15 Thread Pavel Machek
Hi! > I understand Tony already applied this one. I'd have a few comments below, > could you address them in another patch, please? Yes. > > + rear_camera: camera@0 { > > + compatible = "linux,camera"; > > + > > + module { > > + model = "TCM8341MD"; > > +

Re: [PATCH] nokia n900: update dts with camera support

2017-08-14 Thread Tony Lindgren
* Sakari Ailus [170814 13:20]: > Hi Pavel, > > Thanks for the patch. > > I understand Tony already applied this one. I'd have a few comments below, > could you address them in another patch, please? Oops sorry about that. It looked trivial enough for me. Yes an incremental patces to follow-up p

Re: [PATCH] nokia n900: update dts with camera support

2017-08-14 Thread Sakari Ailus
Hi Pavel, Thanks for the patch. I understand Tony already applied this one. I'd have a few comments below, could you address them in another patch, please? On Thu, Aug 10, 2017 at 10:49:23PM +0200, Pavel Machek wrote: > > Add camera support to N900 dts. Also add a note about MMC & debugging. >

Re: [PATCH] nokia n900: update dts with camera support

2017-08-14 Thread Tony Lindgren
* Pali Rohár [170813 08:38]: > On Thursday 10 August 2017 22:49:23 Pavel Machek wrote: > > > > Add camera support to N900 dts. Also add a note about MMC & debugging. > > > > Signed-off-by: Pavel Machek > > Looks good, > > Acked-by: Pali Rohár Applying into omap-for-v4.14/dt-v2 thanks. Tony

Re: [PATCH] nokia n900: update dts with camera support

2017-08-13 Thread Pali Rohár
On Thursday 10 August 2017 22:49:23 Pavel Machek wrote: > > Add camera support to N900 dts. Also add a note about MMC & debugging. > > Signed-off-by: Pavel Machek Looks good, Acked-by: Pali Rohár > > diff --git a/arch/arm/boot/dts/omap3-n900.dts > b/arch/arm/boot/dts/omap3-n900.dts > index

[PATCH] nokia n900: update dts with camera support

2017-08-10 Thread Pavel Machek
Add camera support to N900 dts. Also add a note about MMC & debugging. Signed-off-by: Pavel Machek diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index 49f3708..b1be53d 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -14