Re: [PATCH] nilfs2: do not use unexported cpu_to_le32()/le32_to_cpu() in uapi header

Yamada-san, > To automate this testing, I will merge the following for 5.3-rc1: > https://patchwork.kernel.org/patch/11024715/ Thank you. I could get the series through linux-next tree, and could reproduce the build error by enabling the new coverage test for nilfs2_ondisk.h. Acked-by: Ryusuke

Re: [PATCH] nilfs2: do not use unexported cpu_to_le32()/le32_to_cpu() in uapi header

Konishi-san, On Sun, Jul 7, 2019 at 3:11 PM Ryusuke Konishi wrote: > > Yamada-san, > > I'm sorry for not being able to follow. > > Could you tell me how did you find the build error? > Still I cannot reproduce the error in my environment. "You can compile UAPI headers in kernel-space" does not

Re: [PATCH] nilfs2: do not use unexported cpu_to_le32()/le32_to_cpu() in uapi header

Yamada-san, I'm sorry for not being able to follow. Could you tell me how did you find the build error? Still I cannot reproduce the error in my environment. Or, if it's right that we should not use cpu_to_le{16,32,64}/le{16,32,64}_to_cpu() in UAPI header files, I will acknowledge the change an

Re: [PATCH] nilfs2: do not use unexported cpu_to_le32()/le32_to_cpu() in uapi header

Hi Andrew, On Sun, Jul 7, 2019 at 12:38 PM Andrew Morton wrote: > > Seems fairly serious. I'm thinking this needs a cc:stable? Ah, yes. Cc: linux-stable # 4.9 Fixes: e63e88bc53ba ("nilfs2: move ioctl interface and disk layout to uapi separately") Thanks. -- Best Regards Masahiro Yamada

Re: [PATCH] nilfs2: do not use unexported cpu_to_le32()/le32_to_cpu() in uapi header

On Wed, 5 Jun 2019 14:30:06 +0900 Masahiro Yamada wrote: > cpu_to_le32/le32_to_cpu is defined in include/linux/byteorder/generic.h, > which is not exported to user-space. > > UAPI headers must use the ones prefixed with double-underscore. > > Detected by compile-testing exported headers: > >

Re: [PATCH] nilfs2: do not use unexported cpu_to_le32()/le32_to_cpu() in uapi header

Hi Andrew, Could you pick up this? The maintainer of nilfs2 is silent, but this is obviously build error. Masahiro Yamada On Wed, Jun 5, 2019 at 2:32 PM Masahiro Yamada wrote: > > cpu_to_le32/le32_to_cpu is defined in include/linux/byteorder/generic.h, > which is not exported to user-space. >

[PATCH] nilfs2: do not use unexported cpu_to_le32()/le32_to_cpu() in uapi header

cpu_to_le32/le32_to_cpu is defined in include/linux/byteorder/generic.h, which is not exported to user-space. UAPI headers must use the ones prefixed with double-underscore. Detected by compile-testing exported headers: ./usr/include/linux/nilfs2_ondisk.h: In function ‘nilfs_checkpoint_set_snap