Re: [PATCH] nilfs2: Fix reference count leak in nilfs_sysfs_create_snapshot_group()

2020-05-28 Thread Markus Elfring
> kobject_init_and_add() takes reference even when it fails. It will be helpful to mention which object is referenced here, won't it? > If this function returns an error, kobject_put() must be called to > properly clean up the memory associated with the object. I guess that an imperative wordin

Re: [PATCH] nilfs2: Fix reference count leak in nilfs_sysfs_create_snapshot_group.

2020-05-27 Thread Ryusuke Konishi
Andrew, Apply this, please. Acked-by: Ryusuke Konishi On Thu, May 28, 2020 at 4:55 AM wrote: > > From: Qiushi Wu > > kobject_init_and_add() takes reference even when it fails. > If this function returns an error, kobject_put() must be called to > properly clean up the memory associated with t

[PATCH] nilfs2: Fix reference count leak in nilfs_sysfs_create_snapshot_group.

2020-05-27 Thread wu000273
From: Qiushi Wu kobject_init_and_add() takes reference even when it fails. If this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object. Previous commit "b8eb718348b8" fixed a similar problem. Fixes: a5a7332a291b ("nilfs2: add /sys/f