Re: [PATCH] nfsd: Remove assignments inside conditions

2014-05-22 Thread J. Bruce Fields
On Thu, May 22, 2014 at 04:32:30PM +0200, Benoit Taine wrote: > Assignments should not happen inside an if conditional, but in the line > before. This issue was reported by checkpatch. OK, applying for 3.16. --b. > > The semantic patch that makes this change is as follows > (http://coccinelle.l

[PATCH] nfsd: Remove assignments inside conditions

2014-05-22 Thread Benoit Taine
Assignments should not happen inside an if conditional, but in the line before. This issue was reported by checkpatch. The semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // @@ identifier i1; expression e1; statement S; @@ -if(!(i1 = e1)) S +i1 = e1; +if(!i1) +