Re: [PATCH] nfs-rdma: Fix for FMR leaks

2014-04-11 Thread Chuck Lever
Hi Allen- I reviewed and tested your patch. Comments inline below. On Apr 9, 2014, at 6:40 PM, Allen Andrews wrote: > Two memory region leaks iwere found during testing: > > 1. rpcrdma_buffer_create: While allocating RPCRDMA_FRMR's > ib_alloc_fast_reg_mr is called and then ib_alloc_fast_reg_

[PATCH] nfs-rdma: Fix for FMR leaks

2014-04-09 Thread Allen Andrews
Two memory region leaks iwere found during testing: 1. rpcrdma_buffer_create: While allocating RPCRDMA_FRMR's ib_alloc_fast_reg_mr is called and then ib_alloc_fast_reg_page_list is called. If ib_alloc_fast_reg_page_list returns an error it bails out of the routine dropping the last ib_alloc_fa

[PATCH] nfs-rdma: Fix for FMR leaks

2014-04-09 Thread Allen Andrews
Two memory region leaks iwere found during testing: 1. rpcrdma_buffer_create: While allocating RPCRDMA_FRMR's ib_alloc_fast_reg_mr is called and then ib_alloc_fast_reg_page_list is called. If ib_alloc_fast_reg_page_list returns an error it bails out of the routine dropping the last ib_alloc_fast_

[PATCH] nfs-rdma: Fix for FMR leaks

2014-04-09 Thread Allen Andrews
Two memory region leaks iwere found during testing: 1. rpcrdma_buffer_create: While allocating RPCRDMA_FRMR's ib_alloc_fast_reg_mr is called and then ib_alloc_fast_reg_page_list is called. If ib_alloc_fast_reg_page_list returns an error it bails out of the routine dropping the last ib_alloc_fast_