Re: [PATCH] nfs: fix null checking in nfs_get_option_str()

2013-01-04 Thread Myklebust, Trond
On Fri, 2013-01-04 at 03:22 -0500, Xi Wang wrote: > The following null pointer check is broken. > > *option = match_strdup(args); > return !option; > > The pointer `option' must be non-null, and thus `!option' is always false. > Use `!*option' instead. > > The bug was introduced in c

[PATCH] nfs: fix null checking in nfs_get_option_str()

2013-01-04 Thread Xi Wang
The following null pointer check is broken. *option = match_strdup(args); return !option; The pointer `option' must be non-null, and thus `!option' is always false. Use `!*option' instead. The bug was introduced in commit c5cb09b6f8 ("Cleanup: Factor out some cut-and-paste code."