Re: [PATCH] nfs: fix congestion control -v4

2007-02-20 Thread Peter Zijlstra
On Fri, 2007-01-26 at 00:51 -0800, Andrew Morton wrote: > On Fri, 26 Jan 2007 09:03:37 +0100 > Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > > On Thu, 2007-01-25 at 22:04 -0800, Andrew Morton wrote: > > > On Thu, 25 Jan 2007 21:31:43 -0800 (PST) > > > Christoph Lameter <[EMAIL PROTECTED]> wrote: >

Re: [PATCH] nfs: fix congestion control -v4

2007-01-26 Thread Peter Zijlstra
On Fri, 2007-01-26 at 00:51 -0800, Andrew Morton wrote: > A patch against next -mm would suit, thanks. > > (But we already use atomic_long_t in generic code?) but there is currently no atomic_long_{inc,dec}_return, or any atomic_long_*_return function for that matter. Mathieu adds these missing

Re: [PATCH] nfs: fix congestion control -v4

2007-01-26 Thread Andrew Morton
On Fri, 26 Jan 2007 09:03:37 +0100 Peter Zijlstra <[EMAIL PROTECTED]> wrote: > On Thu, 2007-01-25 at 22:04 -0800, Andrew Morton wrote: > > On Thu, 25 Jan 2007 21:31:43 -0800 (PST) > > Christoph Lameter <[EMAIL PROTECTED]> wrote: > > > > > On Thu, 25 Jan 2007, Andrew Morton wrote: > > > > > > > a

Re: [PATCH] nfs: fix congestion control -v4

2007-01-26 Thread Peter Zijlstra
On Fri, 2007-01-26 at 09:00 +0100, Peter Zijlstra wrote: > On Thu, 2007-01-25 at 21:02 -0800, Andrew Morton wrote: > > On Thu, 25 Jan 2007 16:32:28 +0100 > > Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > > > > +long congestion_wait_interruptible(int rw, long timeout) > > > +{ > > > + long ret; > >

Re: [PATCH] nfs: fix congestion control -v4

2007-01-26 Thread Peter Zijlstra
On Thu, 2007-01-25 at 22:04 -0800, Andrew Morton wrote: > On Thu, 25 Jan 2007 21:31:43 -0800 (PST) > Christoph Lameter <[EMAIL PROTECTED]> wrote: > > > On Thu, 25 Jan 2007, Andrew Morton wrote: > > > > > atomic_t is 32-bit. Put 16TB of memory under writeback and blam. > > > > We have systems wi

Re: [PATCH] nfs: fix congestion control -v4

2007-01-26 Thread Peter Zijlstra
On Thu, 2007-01-25 at 21:02 -0800, Andrew Morton wrote: > On Thu, 25 Jan 2007 16:32:28 +0100 > Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > > +long congestion_wait_interruptible(int rw, long timeout) > > +{ > > + long ret; > > + DEFINE_WAIT(wait); > > + wait_queue_head_t *wqh = &congestion_

Re: [PATCH] nfs: fix congestion control -v4

2007-01-25 Thread Christoph Lameter
On Thu, 25 Jan 2007, Andrew Morton wrote: > > We have systems with 8TB main memory and are able to get to 16TB. > > But I bet you don't use 4k pages on 'em ;) IA64 can be configured for 4k pagesize but yes 16k is the default. There are plans to go much higher though. Plus there may be other rea

Re: [PATCH] nfs: fix congestion control -v4

2007-01-25 Thread Andrew Morton
On Thu, 25 Jan 2007 21:31:43 -0800 (PST) Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Thu, 25 Jan 2007, Andrew Morton wrote: > > > atomic_t is 32-bit. Put 16TB of memory under writeback and blam. > > We have systems with 8TB main memory and are able to get to 16TB. But I bet you don't use

Re: [PATCH] nfs: fix congestion control -v4

2007-01-25 Thread Christoph Lameter
On Thu, 25 Jan 2007, Andrew Morton wrote: > atomic_t is 32-bit. Put 16TB of memory under writeback and blam. We have systems with 8TB main memory and are able to get to 16TB. Better change it now. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH] nfs: fix congestion control -v4

2007-01-25 Thread Andrew Morton
On Thu, 25 Jan 2007 16:32:28 +0100 Peter Zijlstra <[EMAIL PROTECTED]> wrote: > Hopefully the last version ;-) > > > --- > Subject: nfs: fix congestion control > > The current NFS client congestion logic is severly broken, it marks the > backing > device congested during each nfs_writepages() c

Re: [PATCH] nfs: fix congestion control -v4

2007-01-25 Thread Andrew Morton
On Thu, 25 Jan 2007 16:32:28 +0100 Peter Zijlstra <[EMAIL PROTECTED]> wrote: > +long congestion_wait_interruptible(int rw, long timeout) > +{ > + long ret; > + DEFINE_WAIT(wait); > + wait_queue_head_t *wqh = &congestion_wqh[rw]; > + > + prepare_to_wait(wqh, &wait, TASK_INTERRUPTIBL

[PATCH] nfs: fix congestion control -v4

2007-01-25 Thread Peter Zijlstra
Hopefully the last version ;-) --- Subject: nfs: fix congestion control The current NFS client congestion logic is severly broken, it marks the backing device congested during each nfs_writepages() call but doesn't mirror this in nfs_writepage() which makes for deadlocks. Also it implements its