Re: [PATCH] nfp: abm: fix a memory leak bug

2020-05-04 Thread David Miller
From: wu000...@umn.edu Date: Sat, 2 May 2020 17:42:59 -0500 > From: Qiushi Wu > > In function nfp_abm_vnic_set_mac, pointer nsp is allocated by nfp_nsp_open. > But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released, > which can lead to a memory leak bug. Fix this issue by adding >

Re: [PATCH] nfp: abm: fix a memory leak bug

2020-05-04 Thread Jakub Kicinski
On Sat, 2 May 2020 17:42:59 -0500 wu000...@umn.edu wrote: > From: Qiushi Wu > > In function nfp_abm_vnic_set_mac, pointer nsp is allocated by nfp_nsp_open. > But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released, > which can lead to a memory leak bug. Fix this issue by adding > nf

Re: [PATCH] nfp: abm: fix a memory leak bug

2020-05-03 Thread Markus Elfring
… > Fix this issue by adding nfp_nsp_close(nsp) in the error path. How do you think about a wording variant like the following? Subject: [PATCH v2] nfp: abm: Fix incomplete release of system resources in nfp_abm_vnic_set_mac() Change description: … Thus add a call of the function

[PATCH] nfp: abm: fix a memory leak bug

2020-05-02 Thread wu000273
From: Qiushi Wu In function nfp_abm_vnic_set_mac, pointer nsp is allocated by nfp_nsp_open. But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released, which can lead to a memory leak bug. Fix this issue by adding nfp_nsp_close(nsp) in the error path. Signed-off-by: Qiushi Wu --- dri