Re: [PATCH] nf_nat_h323.c unneeded rcu_dereference() calls

2007-10-30 Thread Paul E. McKenney
On Tue, Oct 30, 2007 at 03:06:20PM +0100, Patrick McHardy wrote: > Paul E. McKenney wrote: > >Hello! > > > >While reviewing rcu_dereference() uses, I came across a number of cases > >where I couldn't see how the rcu_dereference() helped. One class of > >cases is where the variable is never subsequ

Re: [PATCH] nf_nat_h323.c unneeded rcu_dereference() calls

2007-10-30 Thread Patrick McHardy
Paul E. McKenney wrote: Hello! While reviewing rcu_dereference() uses, I came across a number of cases where I couldn't see how the rcu_dereference() helped. One class of cases is where the variable is never subsequently dereferenced, so that patches like the following one would be appropriate.

[PATCH] nf_nat_h323.c unneeded rcu_dereference() calls

2007-10-29 Thread Paul E. McKenney
Hello! While reviewing rcu_dereference() uses, I came across a number of cases where I couldn't see how the rcu_dereference() helped. One class of cases is where the variable is never subsequently dereferenced, so that patches like the following one would be appropriate. So, what am I missing he