unbind [was: Re: [PATCH] netlink: have netlink per-protocol bind function return] an error code.

2014-03-25 Thread Richard Guy Briggs
On 14/03/24, Richard Guy Briggs wrote: > On 14/03/24, Richard Guy Briggs wrote: > > On 14/03/23, David Miller wrote: > > > From: Richard Guy Briggs > > > Date: Fri, 21 Mar 2014 12:39:11 -0400 Ok, sorry for all the noise. I had a problem between chair and keyboard which can explain the number of

Re: [PATCH] netlink: have netlink per-protocol bind function return an error code.

2014-03-24 Thread Richard Guy Briggs
On 14/03/24, Richard Guy Briggs wrote: > On 14/03/23, David Miller wrote: > > From: Richard Guy Briggs > > Date: Fri, 21 Mar 2014 12:39:11 -0400 > > > > > @@ -1441,6 +1441,17 @@ static int netlink_bind(struct socket *sock, > > > struct sockaddr *addr, > > > if (!nladdr->nl_groups && (nlk->grou

Re: [PATCH] netlink: have netlink per-protocol bind function return an error code.

2014-03-24 Thread Richard Guy Briggs
On 14/03/23, David Miller wrote: > From: Richard Guy Briggs > Date: Fri, 21 Mar 2014 12:39:11 -0400 > > > @@ -1441,6 +1441,17 @@ static int netlink_bind(struct socket *sock, struct > > sockaddr *addr, > > if (!nladdr->nl_groups && (nlk->groups == NULL || !(u32)nlk->groups[0])) > >

Re: [PATCH] netlink: have netlink per-protocol bind function return an error code.

2014-03-22 Thread David Miller
From: Richard Guy Briggs Date: Fri, 21 Mar 2014 12:39:11 -0400 > @@ -1441,6 +1441,17 @@ static int netlink_bind(struct socket *sock, struct > sockaddr *addr, > if (!nladdr->nl_groups && (nlk->groups == NULL || !(u32)nlk->groups[0])) > return 0; > > + if (nlk->netlink_bi

[PATCH] netlink: have netlink per-protocol bind function return an error code.

2014-03-21 Thread Richard Guy Briggs
Have the netlink per-protocol optional bind function return an int error code rather than void to signal a failure. This will enable netlink protocols to perform extra checks including capabilities and permissions verifications when updating memberships in multicast groups. In netlink_bind() and