Re: [PATCH] netdev: pktgen xmit packet through vlan interface

2014-05-05 Thread Zhouyi Zhou
> You could just force pktgen to not support multi-skb on vlan interfaces? > > I thought we went through this a year or two ago and came up with > something like a 'pktgen-challenged' network interface flag? Ah yes, IFF_TX_SKB_SHARING does the job, very sorry for missing that, as matter of fact,

Re: [PATCH] netdev: pktgen xmit packet through vlan interface

2014-05-05 Thread Ben Greear
On 05/05/2014 08:12 AM, Jesper Dangaard Brouer wrote: > On Fri, 02 May 2014 07:00:00 -0700 > John Fastabend wrote: > >> On 5/2/2014 6:19 AM, Jesper Dangaard Brouer wrote: >>> On Fri, 2 May 2014 15:18:12 +0800 >>> Zhouyi Zhou wrote: >>> As http://www.spinics.net/lists/netdev/msg165015.html

Re: [PATCH] netdev: pktgen xmit packet through vlan interface

2014-05-05 Thread Jiri Pirko
Fri, May 02, 2014 at 09:18:12AM CEST, zhouzho...@gmail.com wrote: >As http://www.spinics.net/lists/netdev/msg165015.html >pktgen generates shared packet through vlan interface will cause >oops because of duplicate entering tc queue. > >Try to solve this problem by means of packet clone instead of s

Re: [PATCH] netdev: pktgen xmit packet through vlan interface

2014-05-05 Thread Jesper Dangaard Brouer
On Fri, 02 May 2014 07:00:00 -0700 John Fastabend wrote: > On 5/2/2014 6:19 AM, Jesper Dangaard Brouer wrote: > > On Fri, 2 May 2014 15:18:12 +0800 > > Zhouyi Zhou wrote: > > > >> As http://www.spinics.net/lists/netdev/msg165015.html > >> pktgen generates shared packet through vlan interface wi

Re: [PATCH] netdev: pktgen xmit packet through vlan interface

2014-05-02 Thread Zhouyi Zhou
Thank Sergei for reviewing. I think On Sat, May 3, 2014 at 12:18 AM, Sergei Shtylyov wrote: >> + >> + if (pkt_dev->clone_skb && is_vlan_dev(odev)) { >> + nskb = skb_clone(pkt_dev->skb, GFP_ATOMIC); >> + ret = -ENOMEM; >> + if (nskb) >> +

Re: [PATCH] netdev: pktgen xmit packet through vlan interface

2014-05-02 Thread Sergei Shtylyov
Hello. On 05/02/2014 11:18 AM, Zhouyi Zhou wrote: As http://www.spinics.net/lists/netdev/msg165015.html pktgen generates shared packet through vlan interface will cause oops because of duplicate entering tc queue. Try to solve this problem by means of packet clone instead of sharing. Sign

Re: [PATCH] netdev: pktgen xmit packet through vlan interface

2014-05-02 Thread Zhouyi Zhou
Thanks for reviewing On Fri, May 2, 2014 at 10:00 PM, John Fastabend wrote: > On 5/2/2014 6:19 AM, Jesper Dangaard Brouer wrote: >> >> On Fri, 2 May 2014 15:18:12 +0800 >> Zhouyi Zhou wrote: >> >>> As http://www.spinics.net/lists/netdev/msg165015.html >>> pktgen generates shared packet through

Re: [PATCH] netdev: pktgen xmit packet through vlan interface

2014-05-02 Thread John Fastabend
On 5/2/2014 6:19 AM, Jesper Dangaard Brouer wrote: On Fri, 2 May 2014 15:18:12 +0800 Zhouyi Zhou wrote: As http://www.spinics.net/lists/netdev/msg165015.html pktgen generates shared packet through vlan interface will cause oops because of duplicate entering tc queue. Try to solve this proble

Re: [PATCH] netdev: pktgen xmit packet through vlan interface

2014-05-02 Thread Jesper Dangaard Brouer
On Fri, 2 May 2014 15:18:12 +0800 Zhouyi Zhou wrote: > As http://www.spinics.net/lists/netdev/msg165015.html > pktgen generates shared packet through vlan interface will cause > oops because of duplicate entering tc queue. > > Try to solve this problem by means of packet clone instead of sharing

[PATCH] netdev: pktgen xmit packet through vlan interface

2014-05-02 Thread Zhouyi Zhou
As http://www.spinics.net/lists/netdev/msg165015.html pktgen generates shared packet through vlan interface will cause oops because of duplicate entering tc queue. Try to solve this problem by means of packet clone instead of sharing. Signed-off-by: Zhouyi Zhou --- net/core/pktgen.c | 20