Re: [PATCH] netdev: Cocci spatch "ptr_ret.spatch"

2013-06-02 Thread Oliver Hartkopp
Hello Thomas, additionally to provide a proper log message it is a usual to provide the coccinelle expression that found the source to be changed. http://lwn.net/Articles/315686/ E.g. like these http://marc.info/?l=linux-netdev&m=135081679626023&w=2 http://marc.info/?l=linux-netdev&m=135194048

Re: [PATCH] netdev: Cocci spatch "ptr_ret.spatch"

2013-06-01 Thread David Miller
From: Thomas Meyer Date: Sat, 01 Jun 2013 11:59:11 +0200 > > Signed-off-by: Thomas Meyer This obscure reference to the cocci path you used to find/fix this problem is insufficient in detail for a commit log message. You must explain exactly what the problem is, and how you fixed it, in full s

[PATCH] netdev: Cocci spatch "ptr_ret.spatch"

2013-06-01 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/net/ethernet/smsc/smc9194.c b/drivers/net/ethernet/smsc/smc9194.c --- a/drivers/net/ethernet/smsc/smc9194.c +++ b/drivers/net/ethernet/smsc/smc9194.c @@ -1571,9 +1571,7 @@ int __init init_module(void) /* copy the parameters from ins

[PATCH] netdev: Cocci spatch "ptr_ret.spatch"

2013-06-01 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/net/ethernet/i825xx/82596.c b/drivers/net/ethernet/i825xx/82596.c --- a/drivers/net/ethernet/i825xx/82596.c +++ b/drivers/net/ethernet/i825xx/82596.c @@ -1527,9 +1527,7 @@ int __init init_module(void) if (debug >= 0) i