Re: [PATCH] net: trivial MLX4_DEBUG dependency fix.

2007-05-10 Thread Roland Dreier
> IMHO default configs must be aimed at production usage scenarios, so > are better off without debugging enabled by default. Except if the > driver is really new / EXPERIMENTAL where the goal is to get it tested > out by all users asap (and no production systems would be using it > anyway).

Re: [PATCH] net: trivial MLX4_DEBUG dependency fix.

2007-05-10 Thread Paul Mundt
On Thu, May 10, 2007 at 04:42:37AM -0700, Roland Dreier wrote: > > CONFIG_MLX4_DEBUG works out to a def_bool y for those that > > have CONFIG_EMBEDDED set. Make it depend on MLX4_CORE.. > > Thanks, applied... (by the way, this bug just results in an > extraneous CONFIG variable being defined, r

Re: [PATCH] net: trivial MLX4_DEBUG dependency fix.

2007-05-10 Thread Satyam Sharma
Hi, On 5/10/07, Roland Dreier <[EMAIL PROTECTED]> wrote: > CONFIG_MLX4_DEBUG works out to a def_bool y for those that > have CONFIG_EMBEDDED set. Make it depend on MLX4_CORE.. Thanks, applied... (by the way, this bug just results in an extraneous CONFIG variable being defined, right? There'

Re: [PATCH] net: trivial MLX4_DEBUG dependency fix.

2007-05-10 Thread Roland Dreier
> CONFIG_MLX4_DEBUG works out to a def_bool y for those that > have CONFIG_EMBEDDED set. Make it depend on MLX4_CORE.. Thanks, applied... (by the way, this bug just results in an extraneous CONFIG variable being defined, right? There's no further breakage -- or am I misunderstanding the situat

[PATCH] net: trivial MLX4_DEBUG dependency fix.

2007-05-09 Thread Paul Mundt
First SLUB_DEBUG, and now this.. CONFIG_MLX4_DEBUG works out to a def_bool y for those that have CONFIG_EMBEDDED set. Make it depend on MLX4_CORE.. I'll let someone else wonder why debugging output is default enabled, this seems to be a worrying trend as of late. Signed-off-by: Paul Mundt <[EMAI